WebsiteBaker Logo
  • *
  • Templates
  • Help
  • Add-ons
  • Download
  • Home
*
Welcome, Guest. Please login or register.

Login with username, password and session length
 

News


WebsiteBaker 2.13.6 is now available!


Will it continue with WB? It goes on! | Geht es mit WB weiter? Es geht weiter!
https://forum.websitebaker.org/index.php/topic,32340.msg226702.html#msg226702


The forum email address board@websitebaker.org is working again
https://forum.websitebaker.org/index.php/topic,32358.0.html


R.I.P Dietmar (luisehahne) and thank you for all your valuable work for WB
https://forum.websitebaker.org/index.php/topic,32355.0.html


* Support WebsiteBaker

Your donations will help to:

  • Pay for our dedicated server
  • Pay for domain registration
  • and much more!

You can donate by clicking on the button below.

Donate with PayPal buttonSpenden mit dem PayPal-Button

  • Home
  • Help
  • Search
  • Login
  • Register

  • WebsiteBaker Community Forum »
  • General Community »
  • WebsiteBaker Website Showcase »
  • ported simple beauty template
  • Print
Pages: [1]   Go Down

Author Topic: ported simple beauty template  (Read 5324 times)

mopey

  • Guest
ported simple beauty template
« on: April 21, 2008, 06:09:54 PM »
So, here's a port of the simple beauty template found at oswd.  I attached the screenshot and the template.  The first screenshot has a custom banner and the second is what you get on a default install.

[gelöscht durch Administrator]
Logged

Offline ruebenwurzel

  • Betatester
  • **
  • Posts: 8544
  • Gender: Male
  • Keep on Rockin
    • Familie Gallas Online
Re: ported simple beauty template
« Reply #1 on: April 21, 2008, 06:15:51 PM »
Hello,

and where is the template for testing?

Matthias
Logged

mopey

  • Guest
Re: ported simple beauty template
« Reply #2 on: April 21, 2008, 06:26:51 PM »
Here is the default. http://engr.isu.edu/pages/test.php

It doesn't validate, but only because the show_menu function adds a target attribute (not sure why).  Anyway, I'll change the doctype to transitional rather than strict and it shouldn't be an issue.
Logged

mopey

  • Guest
Re: ported simple beauty template
« Reply #3 on: April 21, 2008, 06:40:40 PM »
ok validates now.  But I still don't get why you WebsiteBaker folks opted for the show_menu function to spit out non-valid strict html.  Not that I care really at all (I'm far from a validation nut).  so I attached an updated template. the only thing changed is the doctype.

[gelöscht durch Administrator]
Logged

Offline DGEC

  • Posts: 388
  • Gender: Male
    • EbelTech homepage
Re: ported simple beauty template
« Reply #4 on: April 21, 2008, 07:56:38 PM »
Lot of people like the target, but showmenu is fairly old anyway. A lot of the templates may depend on it.

ShowMenu2 (can) generates valid markup and is going to be included in WB 2.7
Logged

mopey

  • Guest
Re: ported simple beauty template
« Reply #5 on: April 21, 2008, 09:08:05 PM »
I do like show_menu2(), and I'm glad it's being included.  Though show_menu2 also will spit out the target at least by default... I think (at least I couldn't get it to not include the target). 

$aMenuOpen has an attribute
[target]        Page target for the <a> tag

that looks promising.   But both

[a]             <a> tag (no class):         '<a href="[url]" target="[target]">'
[ac]            <a> tag including class:    '<a href="[url]" target="[target]" class="[class]">'

specify a target (which I managed to set 'target=""' but couldn't get rid of the target completely).

Not only that, the target attribute seems to be builtin to the core. eg class.frontend, template.inc, many of the admin pages, etc.  I think it would be more of a pain than it's worth to change (and like you said, a lot of people like the target attribute).  But it isn't valid strict xhtml >= 1.0.  Anyway, maybe the showmenu2 page should specify that it generates valid "transitional xhtml 1.0" rather than "xhtml"?  Or maybe I just can't get it working properly.
Logged

Offline ruebenwurzel

  • Betatester
  • **
  • Posts: 8544
  • Gender: Male
  • Keep on Rockin
    • Familie Gallas Online
Re: ported simple beauty template
« Reply #6 on: April 21, 2008, 09:36:41 PM »
Hello,

Quote
Or maybe I just can't get it working properly.

You give the answer to your question in the post above yourself.  :wink: . It is very simple and directly in front of your eyes, think even to simple that you see it.  :-D.

simply change $aItemOpen parameter wich is default:
Code: [Select]
'[li][a][menu_title]</a>'to:
Code: [Select]
'[li]<a href="[url]">[menu_title]</a>'
This gives you a link without target

Matthias
« Last Edit: April 21, 2008, 11:14:46 PM by ruebenwurzel »
Logged

mopey

  • Guest
Re: ported simple beauty template
« Reply #7 on: April 21, 2008, 09:53:20 PM »
ahh, yes.  Thanks Matthias.
Logged

  • Print
Pages: [1]   Go Up
  • WebsiteBaker Community Forum »
  • General Community »
  • WebsiteBaker Website Showcase »
  • ported simple beauty template
 

  • SMF 2.0.19 | SMF © 2017, Simple Machines
  • XHTML
  • RSS
  • WAP2