WebsiteBaker Logo
  • *
  • Templates
  • Help
  • Add-ons
  • Download
  • Home
*
Welcome, Guest. Please login or register.

Login with username, password and session length
 

News


WebsiteBaker 2.13.8 is now available!


R.I.P Dietmar (luisehahne) and thank you for all your valuable work for WB
https://forum.websitebaker.org/index.php/topic,32355.0.html


* Support WebsiteBaker

Your donations will help to:

  • Pay for our dedicated server
  • Pay for domain registration
  • and much more!

You can donate by clicking on the button below.


  • Home
  • Help
  • Search
  • Login
  • Register

  • WebsiteBaker Community Forum »
  • General Community »
  • Global WebsiteBaker 2.8.x discussion »
  • typo in show_menu2
  • Print
Pages: [1]   Go Down

Author Topic: typo in show_menu2  (Read 13348 times)

Offline Martin Hecht

  • Betatester
  • **
  • Posts: 608
  • Gender: Male
    • meine Homepage
typo in show_menu2
« on: March 26, 2014, 08:32:02 AM »
I'm not sure if this is the right place to report, but I have found a pretty obvious typo in show_menu2:
SM2_NO_TITLE should be bit 13 according to the comment, but in fact it is "(bit1 || bit12)" , the following patch corrects this (sorry, I messed up the time stamp of the file):

diff -ru A/modules/show_menu2/include.php B/modules/show_menu2/include.php
--- A/modules/show_menu2/include.php    2014-03-26 07:22:54.372884948 +0100
+++ B/modules/show_menu2/include.php    2014-03-25 22:25:00.025956985 +0100
@@ -38,7 +38,7 @@
 define('SM2_CURRTREE',     0x0400); // bit 10
 define('SM2_SHOWHIDDEN',   0x0800); // bit 11
 define('SM2_XHTML_STRICT', 0x1000); // bit 12
-define('SM2_NO_TITLE',     0x1001); // bit 13
+define('SM2_NO_TITLE',     0x2000); // bit 13
 
 define('_SM2_GROUP_1',  0x000F); // exactly one flag from group 1 is required
« Last Edit: March 26, 2014, 09:12:49 AM by mrbaseman »
Logged

Offline marmot

  • Posts: 1103
Re: typo in show_menu2
« Reply #1 on: March 26, 2014, 02:19:22 PM »
Hi,

can confirm. Saw this when patching sm2 for an additonal option here. But it's also obvious that there is no influence on fuctionallity at all.

regards
Logged

  • Print
Pages: [1]   Go Up
  • WebsiteBaker Community Forum »
  • General Community »
  • Global WebsiteBaker 2.8.x discussion »
  • typo in show_menu2
 

  • SMF 2.0.19 | SMF © 2017, Simple Machines
  • XHTML
  • RSS
  • WAP2