WBLingual - how to get rid of ugly URL

[CodeALot]

When switching from one language to another (in this case, to English) the URL of the 'landing page' shows unwanted variables.   (?_wb=.... etc)

Code: [Select]

https://exampledomain.com/en/what-we-do/?_wb=en/what-we-do/

Am I overlooking something? Doing something wrong?   I don't want ugly URL's

WB 2.12.2 r379
WBLingual 2.0.2
ShortURL active

[hgs]

I can confirm that,
https://domäne.org/de/gallery/?_wb=de/gallery/
AFTER another "click" in the language
https://domäne.org/de/ueber-uns/
it is then clean again, so only when changing the URL via the flags the URL is "wrong".
What do the developers say?

[dbs]

Halrald, you have also shorturl active.
?_wb= is part of the htaccess code for shorturl.

[astricia]

I had this problem on a website a few months ago and contacted Ruud about it, since he developped shorturl. He said this was caused by WebsiteBaker and he made "a small change in class.frontend.php" to prevent this happening. It worked - but unfortunately I don't know what exactly he changed....

I have attached the new class.frontend.php from that particular server (as txt - you need to rename it), so maybe this helps.

Astrid

[hgs]

Halrald, you have also shorturl active.
?_wb= is part of the htaccess code for shorturl.

Yes I have shortURL active

[dbs]

@astricia: thanks, to you and Ruud. Seems to work. File ist from 2.12.1 but the change is the same for 2.12.2
framework/class.frontend.php line 192. change this:

Code: [Select]

\header('Location: '.$this->page_link($this->page['link']).'?'.$_SERVER['QUERY_STRING']);to this

Code: [Select]

\header('Location: '.$this->page_link($this->page['link']));

[hgs]

 
Then, if there are no concerns from the developers, it should be transferred to the next version like this.
@dbs please create a ticket, because my internet is currently very slow on vacation.

[hgs]

Tested on a bilingual site. Everything runs as it should.
Thanks to all

[CodeALot]

Works! Thanks all 

[crnogorac081]

I would like to ask what is happening with link eg. http://wb_url/my_pretty_url/?page=2

Is _get('page') going to be dumped too if we apply the proposed fix

I would suggest to only remove _wb from $_SERVER['QUERY_STRING'] if exists..

[dbs]

Dev Dietmar will take a look at the change. The way I see it, there will be another solution.