Author Topic: Minigallery (v2.5.0) - better again  (Read 1258 times)

Offline Ruud

  • Posts: 3640
  • Gender: Male
  • Do not use PM for help! Please use the forum!
    • Dev4Me - Professional WebsiteBaker Development
Minigallery (v2.5.0) - better again
« on: January 09, 2018, 01:51:59 PM »
Minigallery (v2.5.0) now has the possibility to sort the images. No more naming the images to get them in the correct alphabetical order.
Just drag and drop them around in the backend and sorting is done.

Since version 2.4.0 a new justify script was added that is used for both the square thumbnails as well as when they are different sized.

Captions are also added and the possibility to delete per single image is there now (since version 2.3.0).
Bulk upload was the other big improvement of that version. Just drop your complete album in the module upload section and it should work.

Info and download: https://dev4me.com/modules-snippets/opensource/minigallery-v2/



Offline hgs

  • Betatester
  • **
  • Posts: 924
    • EFG MG
Re: Minigallery (v2.5.0) - better again
« Reply #1 on: January 09, 2018, 02:51:15 PM »
 (Y)
Work very nice. Just tested with WebsiteBaker 2.11 under php7.1.11
LG Harald

"Fange nie an, aufzuhören - höre nie auf, anzufangen." Marcus Tullius Cicero (106-43 v.Chr.)

Offline dbs

  • Betatester
  • **
  • Posts: 7558
  • Gender: Male
  • tioz4ever
    • WebsiteBaker - jQuery-Plugins - Module - Droplets - Tests
Re: Minigallery (v2.5.0) - better again
« Reply #2 on: January 09, 2018, 06:40:45 PM »
My client is happy with the new version.
I didn't explain anything. It was intuitive enough.  (Y)

Thank you, Ruud!

Offline hgs

  • Betatester
  • **
  • Posts: 924
    • EFG MG
Re: Minigallery (v2.5.0) - better again
« Reply #3 on: May 25, 2018, 10:51:26 AM »
Minigallery 2.5.1 throws the following error in the error log
Code: [Select]
Fri, 25 May 2018 08:37:11 +0000 [E_NOTICE] /modules/minigal2/functions.php:[210] from /modules/minigal2/functions.php:[28] isImageFile "getimagesize(): Read error!"
WebsiteBaker 2.12
php 7.2.1
strikt no

What can I do?
LG Harald

"Fange nie an, aufzuhören - höre nie auf, anzufangen." Marcus Tullius Cicero (106-43 v.Chr.)

Offline Ruud

  • Posts: 3640
  • Gender: Male
  • Do not use PM for help! Please use the forum!
    • Dev4Me - Professional WebsiteBaker Development
Re: Minigallery (v2.5.0) - better again
« Reply #4 on: May 25, 2018, 11:33:43 AM »
Minigallery 2.5.1 throws the following error in the error log
Code: [Select]
Fri, 25 May 2018 08:37:11 +0000 [E_NOTICE] /modules/minigal2/functions.php:[210] from /modules/minigal2/functions.php:[28] isImageFile "getimagesize(): Read error!"
The message just means it is trying to check a file that is either no image or a corrupted imagefile.
So, you could check the folder for invalid files.

Offline hgs

  • Betatester
  • **
  • Posts: 924
    • EFG MG
Re: Minigallery (v2.5.0) - better again
« Reply #5 on: May 25, 2018, 11:38:47 AM »
Okay, thanks for the hint. In the FE the pictures are all to see and in the BE I have updated all images again. The message remains unfortunately.
LG Harald

"Fange nie an, aufzuhören - höre nie auf, anzufangen." Marcus Tullius Cicero (106-43 v.Chr.)

Offline Ruud

  • Posts: 3640
  • Gender: Male
  • Do not use PM for help! Please use the forum!
    • Dev4Me - Professional WebsiteBaker Development
Re: Minigallery (v2.5.0) - better again
« Reply #6 on: May 25, 2018, 11:51:49 AM »
It could be some other file was uploaded or created..
Using "delete all" in the module should remove the complete folder and create a new one.

The error (notice) could be handled better by minigal2.
You can try to modify line 210 in functions.php ( /modules/minigal2/functions.php )
Code: [Select]
if(@!is_array(getimagesize($filename))){into
Code: [Select]
if(!is_array(@getimagesize($filename))){
That might help suppressing the message.

Offline hgs

  • Betatester
  • **
  • Posts: 924
    • EFG MG
Re: Minigallery (v2.5.0) - better again
« Reply #7 on: May 25, 2018, 12:15:15 PM »
I have deleted all images, the directories wash empty afterwards.
I changed the line 210 so.
Then the pictures uploaded again via the BE from the module and the pictures updated.
The error message still appears.

It's about this site
https://reverend-biola.org/
LG Harald

"Fange nie an, aufzuhören - höre nie auf, anzufangen." Marcus Tullius Cicero (106-43 v.Chr.)

Offline hgs

  • Betatester
  • **
  • Posts: 924
    • EFG MG
Re: Minigallery (v2.5.0) - better again
« Reply #8 on: May 25, 2018, 12:50:25 PM »
Have now tested the php version of 7.2 to 7.1 and 7.0, the error message remains unfortunately.
LG Harald

"Fange nie an, aufzuhören - höre nie auf, anzufangen." Marcus Tullius Cicero (106-43 v.Chr.)

Offline hgs

  • Betatester
  • **
  • Posts: 924
    • EFG MG
Re: Minigallery (v2.5.0) - better again
« Reply #9 on: May 25, 2018, 01:02:29 PM »
Have now installed a fresh Wb 2.12 with php 7.2 and minigallery 2.5.1.
These error messages come only with the installation of the module minigallery

Code: [Select]
Fri, 25 May 2018 10:57:01 +0000 [E_NOTICE] /modules/minigal2/functions.php:[210] from /modules/minigal2/functions.php:[28] isImageFile "getimagesize(): Read error!"
Fri, 25 May 2018 10:57:25 +0000 [E_NOTICE] /modules/minigal2/save.php:[77] from /modules/minigal2/save.php:[77] WbErrorHandler "Undefined index: PAGES"
Fri, 25 May 2018 10:57:27 +0000 [E_NOTICE] /modules/minigal2/functions.php:[210] from /modules/minigal2/functions.php:[28] isImageFile "getimagesize(): Read error!""

Where the second message is fixed quickly, strange are the messages to pictures that have not yet been uploaded ??
LG Harald

"Fange nie an, aufzuhören - höre nie auf, anzufangen." Marcus Tullius Cicero (106-43 v.Chr.)

Offline Ruud

  • Posts: 3640
  • Gender: Male
  • Do not use PM for help! Please use the forum!
    • Dev4Me - Professional WebsiteBaker Development
Re: Minigallery (v2.5.0) - better again
« Reply #10 on: May 25, 2018, 02:02:09 PM »
The message is shown by WB when your error-reporting is set to "Development" mode.
For some reason WB switches off the standard way of suppressing errors (using the @ character) when this setting is used.

So, nothing wrong. Just a little bit too critical error reporting.

Offline noname8

  • Posts: 139
Re: Minigallery (v2.5.0) - better again
« Reply #11 on: August 24, 2018, 08:34:21 AM »
Somehow the minigallery sorting does not work.
I can't explain it, i have inserted the photos with sort numbers about 9000 but seems it has no effect.
Manually dragging file works, but number to sql comes 99 107 or similiar.

In the code there is sort parameter many place but no sort setting in the admin gallery settings ?

Offline noname8

  • Posts: 139
Re: Minigallery (v2.5.0) - better again
« Reply #12 on: August 24, 2018, 09:17:23 AM »
so the sorting is not the number but | list in the settings.


Found a bug, when you delete image the description row in the mod_minigal2img table does not get deleted

Offline Ruud

  • Posts: 3640
  • Gender: Male
  • Do not use PM for help! Please use the forum!
    • Dev4Me - Professional WebsiteBaker Development
Re: Minigallery (v2.5.0) - better again
« Reply #13 on: August 24, 2018, 10:29:22 AM »
Somehow the minigallery sorting does not work.
I can't explain it, i have inserted the photos with sort numbers about 9000 but seems it has no effect.
Manually dragging file works, but number to sql comes 99 107 or similiar.
Not really sure what you mean here..

Remember that for sorting routines 10000 comes before 99.
Sorting is initially done per filename characters , so the 1 from 10000 is lower than the 9 from 99.
If you want to sort numeric imagenames correctly use 00001, 00002 etc..

After this first load the sorted filenames are stored in the settings and you can drag&drop them around for manual sorting. Any additional uploads will be appended behind the existing sortlist (sorted on filename) whenever the images are reloaded (either backend/frontend page refresh).

In the code there is sort parameter many place but no sort setting in the admin gallery settings ?
There is a field "sorting" in the wb_mod_minigal2 table. It is created on module install or when upgrading from older versions.

Found a bug, when you delete image the description row in the mod_minigal2img table does not get deleted
This is not a bug, it is intentionally kept to be able to use the same caption whenever the same image (or complete gallery) is uploaded again (replaced).