Author Topic: Google sitemap.xml Generator not showing posts from 2.12 added news pages  (Read 113 times)

Offline kibmcz

  • Posts: 228
  • Gender: Male
    • KComputer  Zone
Not sure where to post this as the post for Google sitemap.xml Generator module is locked and there is no 2.12.1 section.

Anyway found that the existing pre-2.12.1 news posts were showing in the Google sitemap.xml Generator generated output but no posts showed up from a news section added on 2.12.1.

Not sure where this bug lies? News module or Google sitemap.xml Generator module?

Hope to have this sorted out as this does break SEO a bit.

Offline Ruud

  • Posts: 3639
  • Gender: Male
  • Do not use PM for help! Please use the forum!
    • Dev4Me - Professional WebsiteBaker Development
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #1 on: December 04, 2018, 10:06:10 AM »
If you are using this one: https://dev4me.com/modules-snippets/opensource/google-sitemap-xml/
It should work fine in wb2.12.1 (tested in fresh install)

Offline kibmcz

  • Posts: 228
  • Gender: Male
    • KComputer  Zone
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #2 on: December 04, 2018, 10:09:47 AM »
That's the one I'm using but for some odd reason on the 2.10.x upgraded to 2.12.1 install its only listing news posts from the news section that existed before the upgrade none from the news section added post upgrade shown.

Edit: Tested on my clean install to 2.12.1 on local test server and it shows no news posts.

Offline Ruud

  • Posts: 3639
  • Gender: Male
  • Do not use PM for help! Please use the forum!
    • Dev4Me - Professional WebsiteBaker Development
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #3 on: December 04, 2018, 10:17:31 AM »
If you are talking about your own website (in your profile), I can see the last posts in the sitemap  8-)

Offline kibmcz

  • Posts: 228
  • Gender: Male
    • KComputer  Zone
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #4 on: December 04, 2018, 10:20:38 AM »
That's the pre-upgrade news section that's working. The one that's not listing is the articles page which has 32 posts.  So if my math is correct there should more than 69 entrys on the site map (101 to be exact).

Offline Ruud

  • Posts: 3639
  • Gender: Male
  • Do not use PM for help! Please use the forum!
    • Dev4Me - Professional WebsiteBaker Development
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #5 on: December 04, 2018, 10:38:28 AM »
There might be a problem if that (news)page is set to "hidden" or when there is another section in that page above the news section.

You can try to remove line 328 from google_sitemap.php and see what happens (would fix the second problem):
Code: [Select]
if (!in_array($news['section_id'], $public)) continue;

Offline kibmcz

  • Posts: 228
  • Gender: Male
    • KComputer  Zone
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #6 on: December 04, 2018, 10:56:34 AM »
Hmm commenting out that line causes them to show but that page is set to default public access with only change on news module being enabling comments. Not sure the actual cause is if the page/module are set to default public.

Offline Ruud

  • Posts: 3639
  • Gender: Male
  • Do not use PM for help! Please use the forum!
    • Dev4Me - Professional WebsiteBaker Development
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #7 on: December 04, 2018, 11:06:36 AM »
And no other sections on that page?
That line checks to see if the page was public, hoever the pages loop just stored the first section_id it sees (is a real bug that needs to be fixed).

Offline kibmcz

  • Posts: 228
  • Gender: Male
    • KComputer  Zone
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #8 on: December 04, 2018, 11:10:23 AM »
There was a currently non populated WYSIWYG section on the top but they still wouldn't show even if on the bottom. Posts from that section showed after removing WYSIWYG from that page.

What's puzzling it's not having any issue with the WYSIWYG on top News on bottom setup on the pre-upgrade page.

Offline Ruud

  • Posts: 3639
  • Gender: Male
  • Do not use PM for help! Please use the forum!
    • Dev4Me - Professional WebsiteBaker Development
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #9 on: December 04, 2018, 11:25:47 AM »
It is probably based on the section_id (I will have to look). So whatever was created first is first in the database..

I will try to fix this issue and release a new google_sitemap.php soon.. (too late for you though :-) )

Offline kibmcz

  • Posts: 228
  • Gender: Male
    • KComputer  Zone
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #10 on: December 04, 2018, 11:32:28 AM »
Glad the issue is somewhat worked out... for now i can stick html content for that page in the news module loops until the bug is sorted out.

Thanks for helping to sort that out :)

Offline Ruud

  • Posts: 3639
  • Gender: Male
  • Do not use PM for help! Please use the forum!
    • Dev4Me - Professional WebsiteBaker Development
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #11 on: December 04, 2018, 12:17:30 PM »

Offline kibmcz

  • Posts: 228
  • Gender: Male
    • KComputer  Zone
Re: Google sitemap.xml Generator not showing posts from 2.12 added news pages
« Reply #12 on: December 04, 2018, 07:52:28 PM »
Works as expected now :)

Thanks for a fast fix.

 

postern-length