The solution for Short (SEO Friendly) URL's

[Ruud]

Can you share the link where this is happening? (PM if you do not want to make it public)

Never mind, I found the problem.

The form module, since WB2.8.2, suddenly uses the $_SERVER['SCRIPT_NAME'] variable as the url to post the data.
The script_name is the script that is used after rewrites. This means it will use the /short.php for posting the data.
Previous versions of the form module were using $_SERVER['PHP_SELF']. That will show the original request before any rewriting.

The good solution would be to modify the form module (view.php) and modify all 'SCRIPT_NAME' into 'PHP_SELF'.

The dirty solution is to modify /short.php and add before line 40  (  require.... ) a line that says:
$_SERVER['SCRIPT_NAME'] = $_SERVER['PHP_SELF'];
This will fake the correct value in the SCRIPT_NAME variable..
Note: This could break (or fix as well) other modules that make use of that variable!
 

[dbs]

have taked the good solution and it works 

now i see a problem with the news module. "read more" makes nothing.

[Ruud]

now i see a problem with the news module. "read more" makes nothing.

I must confess I only tested on 2.8.1, there it is working fine  (example www.dev4me.nl/nieuws/ )
I will have a look on a 2.8.2. installation later.

[Bug]

I guess the next step is a version where /posts will also be rewritten to' nieuws' (or whatever the name of the rootparent is)?

[NorHei]

The good solution would be to modify the form module (view.php) and modify all 'SCRIPT_NAME' into 'PHP_SELF'.

Not a good idea:
http://blog.oncode.info/2008/05/07/php_self-ist-boese-potentielles-cross-site-scripting-xss/

Sorry only german, but the code examples should be understandable.

OK, here are some english articles about the problem:
http://seancoates.com/blogs/xss-woes
http://www.mc2design.com/blog/php_self-safe-alternatives

[dbs]

oh my god. i must ruuds "good solution" rechange in my form-module?

[Ruud]

The good solution would be to modify the form module (view.php) and modify all 'SCRIPT_NAME' into 'PHP_SELF'.

Not a good idea:

The form module (since WB2.7) sanitises the PHP_SELF variable so it will not be affected.

Code: [Select]

htmlspecialchars(strip_tags($_SERVER['PHP_SELF']))
The better solution would be that the module would generate the current url out of the WB database. Not using any $_SERVER[] method. 

[Ruud]

I just put a new version (v2.1) on http://short.allwww.nl

This should fix both reported problems.

For redirected pages (the shortened url's) the SCRIPT_NAME variable is now changed with the value of REQUEST_URI. This was already done for the PHP_SELF variable in previous versions, because it would report the wrong url. REQUEST_URI is believed safe to use.
No modifications to the Form modules are needed by this fix.

The news module in 282 is not using defines anymore, so this is changed in the short.php script and is now working in WB282 as well as previous versions.

[dbs]

Now all seems to be allright 
Good script, thx ruud.

[NorHei]

Good Work !

[Sokhim Sim]

Good Job, I have test and use this module. But my question with this plugin why we still have old link work after we change to short URL.

Ex 1: http://www.mywebsite.com/pages/accommodations.php

Ex 2: http://www.mywebsite.com/accommodations/

It work the same link but i want to remove Ex 1. How?

Best Regards, 

[Ruud]

Try adding this to your .htaccess

Code: [Select]

RewriteCond %{REQUEST_URI} pages
RewriteRule ^pages/(.*).php$ /$1/ [R=301,L]

It shoud replace /pages/something/more.php into /something/more/

See it in action on: http://short.allwww.nl/pages/howto/mod_rewrite.php )

[Sokhim Sim]

Thanks it working fine, now work one link something like /accommodations/happy-view-rooms/.

Happy 

[iradj]

Hi Ruud,

I try on a test server (2.8.1, Rev. 1285) and get "500 Internal Server Error". What am I doing wrong?

BR Iradj

[Ruud]

If you do not have any other rules in the .htaccess it could be that your server does not allow rewriting url's.
If you have other rules, you will need to experiment what is causing the conflict.

The error 500 is the error where the server says: "I don't know what, but something is wrong".
So it is very hard to tell what is wrong.

[iradj]

I think you're right. I've just loaded on the server, the modules "download_gallery_2".
In the directory / media / download_gallery is also a ".htaccess" is created. I could not download files from this directory. After I deleted .htaccess did it again.
If the error is actually on my server?

[Ruud]

The "500 Internal Server Error" says it all.
It is a server error.

What you can or cannot do using .htaccess is depending on the server configuration.
You could try asking your hoster (by sending them the .htaccess file) if there is something in the that is not allowed.

[unawave2]

WB generates PERFECT SEF-URLs. The only issue is that URLs depend on Menu-Titles.

In the German section of this forum I wrote some modifications to bypass this restriction:

[dbs]

thx for hint, havn't see it before.

[dbs]

Hello,

i use short-url v2.2 together with the module 404-redirect v0.4 (https://forum.WebsiteBaker.org/index.php/topic,21145.0.html).

It seems the module 404 don't work with short-url (in WB2.8.1 and 2.8.2).
If a page was not found i will kicked to domain.de instead error-page.
Can this confirm somebody?

Have tried to change Location in short.php, but wan't work :

Code: [Select]

header('Location: '.WB_URL);
into: header('Location: '.WB_URL.'/pages/my-error.php');
Some hints are welcome.

dbs

[Ruud]

Try this.. It worked for me

Edit /short.php and add - after the call to get_seo_link() on line 32 - the line:

Code: [Select]

if (!$page_id) $page_id = 11;where 11 should be replaced with the page_id of your 404 page.

see http://short.allwww.nl/this/is/a/wrong/link/

[dbs]

that works   

must bookmark your post, thx ruud.

the redirected page contains /pages/ in the path, but it is better than redirect to start-page.

[Xagone]

i've mod google_sitemap.php to work with short_url

and added
RewriteRule ^sitemap.xml$ google_sitemap_shor turl.php

right after
RewriteRule ^pages/(.*).php$ /$1/ [R=301,L]


so that domain.com/sitemap.xml works like a charm (and added the line:
sitemap: http://www.mydomain.com/sitemap.xml
to the robot.txt)

By the way, sometimes the htaccess needs
Options +FollowSymLinks
and
RewriteBase /
to work properly

[gelöscht durch Administrator]

[dbs]

i have no sitemap.xml.
for google-webmastertools i had submitted the url to google_sitemap.php. google says it is all right.
with your google_sitemap_shor turl.php i do the same?
nothing more is needed if i understand this right.
or i rename to google_sitemap.php.

[Xagone]

google_sitemap.php is Ok, but every single url is "redirected" in the mind of google

google_sitemap_shor turl.php only provides the shorten url, so no redirections

since you submitted google_sitemap.php you should renamed it that way to not cause error on GTools