Author Topic: Bug in class.wb.php  (Read 1732 times)

anfaenger

  • Guest
Bug in class.wb.php
« on: August 13, 2009, 05:06:26 PM »
Hello alltogether,

I found a "bug" in class.wb.php. (Well, it's not really a bug, but a use of a routine with a high payload because it causes a call of a regex parser where that's not needed.)

In line 219 of class.wb.php the command split() is used to divide a string into an array of strings containing peaces of the original string. split() is used to extract data fields on basis of a regex as delimiter.

A more suitably routine due to better performance to do that job is explode(). The routine splits fields contained in a string on basis of another string (not a regex - a regex won't even work here!!!) and therefore causes no call of a regex parser.

In fact, split() is even marked as deprecated starting with PHP 5.3.0  :-o So using explode() instead of split() will avoid difficulties in future versions of WebsiteBaker or WebsiteBaker installations on servers using PHP 5.3.0.

Regards,
Marcus

(sorry for my... let's call it "rough" english, but I'm a little bit out of training...)

Offline Luisehahne

  • WebsiteBaker Org e.V.
  • **
  • Posts: 4366
  • Gender: Male
    • Webdesign und Entwicklung WebsiteBaker
Re: Bug in class.wb.php
« Reply #1 on: August 13, 2009, 05:38:28 PM »
Pls write a ticket on project page

Dietmar
Immer nur von der Zukunft reden, die Gegenwart vergessen und auf die Vergangenheit schimpfen
Neues Unwort: Schnappatmung