WebsiteBaker Community Forum

WebsiteBaker Support (2.8.x) => Modules => Topic started by: daydreamer on January 15, 2013, 10:59:56 AM

Title: Can anyone upgrade CKeditor?
Post by: daydreamer on January 15, 2013, 10:59:56 AM
Could anyone upgrade ckeditor to version 4.0.1 looks awesome and new features  :-D
Title: Re: Can anyone upgrade CKeditor?
Post by: badknight on January 15, 2013, 11:32:08 AM
Could anyone upgrade ckeditor to version 4.0.1 looks awesome and new features  :-D

The Problem with the 4.0 is -> there is no php connector class
- A normal overwriting of the files doesn't work :)
Title: Re: Can anyone upgrade CKeditor?
Post by: daydreamer on January 15, 2013, 03:01:14 PM
So it can be done? maybe just have to wait for some great person to do it  :wink:
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on January 15, 2013, 07:56:00 PM
Hi,

maybe just have to wait for some great person to do it
maybe you don't have to wait anynmore for that great person. Look here (http://www.websitebaker2.org/forum/index.php/topic,24886.msg172046.html#msg172046).

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: NorHei on January 16, 2013, 09:33:49 PM
Thats not right :-(

its the latest version before 4.0 !!!

4.0 does no longer have the php connector class so its not a plain simple upgrade.

sooner or later i will find time to upgrade it to 4.0 but i guess its later :-(
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on January 16, 2013, 10:45:42 PM
Hi,

maybe you don't have to wait anynmore for that great person.
Thats not right :-(
hmm, do you know what maybe means? Maybe means also "maybe not" so everyting is ok.
But yes you are right, think I should try reading more carefully.
Thanks for your cke upgrade anyway.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: NorHei on January 17, 2013, 11:38:44 AM
Maybe means, next project where i need frontend editing  :-D

If you replace the version of the module whith the 4.0 you get no editor and firebug complains about one mising variable . BTW. the php connector class was never needed , it was just there to make embedding more comfortable.
I guess there its just one config var missing.
Title: Re: Can anyone upgrade CKeditor?
Post by: cwsoft on January 17, 2013, 01:00:41 PM
Hi,

not really looked at, but maybe a good starting point from Blackbird can be found here (https://github.com/webbird/LEPTON_2_BlackCat/tree/master/upload/modules/ckeditor4).

Cheers
Title: Re: Can anyone upgrade CKeditor?
Post by: NorHei on January 17, 2013, 05:31:56 PM
hmmm... not really , redoing it from scratch may be faster.
All those ugly "L" stuff there,
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on January 17, 2013, 11:14:09 PM
Hi,

ok just to prove that it's not that difficult to use cke 4.0.1 with wb I upgraded the module using cke 4.0.1 full (https://github.com/ckeditor/ckeditor-releases/tree/4.0.x/full). Just had to use a proper skin and disable some plugins.
Ok, the wb plugins like droplets and wblink don't work and I'm afraid it's not that easy to upgrade them. But as far as I can see, they also don't work in the version mentioned by cwsoft.

Maybe this is helpful for someone.

PS: This is really quick and dirty but looking at the code of the original module I'm not ashamed of that.  :-D

regards

Edith: find latest version below
Title: Re: Can anyone upgrade CKeditor?
Post by: NorHei on January 18, 2013, 11:59:50 AM
Quote
But as far as I can see, they also don't work in the version mentioned by cwsoft.
Correct  :lol:


Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on April 18, 2013, 08:57:10 PM
Hi,

upgraded my version from above by cleaning code a bit and adapting wb plugins to cke 4.
Works fine for me.

regards

Edith: find latest version below
Title: Re: Can anyone upgrade CKeditor?
Post by: nibz on April 18, 2013, 11:24:54 PM
I am sorry to say, but it doesn't load...
Or did i do something wrong?, or forgot something...

Can PM you some demo login details if you like
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on April 19, 2013, 11:54:21 AM
Works fine for me.

for me too
THANKS!!!
Title: Re: Can anyone upgrade CKeditor?
Post by: nibz on April 19, 2013, 02:16:23 PM
i think i have found the problem.

When i set my admin language to German the CKeditor works, but it doesn't work when i set my admin language to English or Dutch.

Gr. Robin
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on April 19, 2013, 03:09:59 PM
go to modules / ckeditor / ckeditor / plugins / wbdroplets / lang /  your favorite language.js (en.js)
and fix this line
CKEDITOR.plugins.se tLang( 'wbdroplets', 'de', {

change the de with the name from the js-File

example:

entry in en.js
CKEDITOR.plugins.se tLang( 'wbdroplets', 'de', {

change to
CKEDITOR.plugins.se tLang( 'wbdroplets', 'en', {

P.S.: if you want or need: translate the other lines in this file
Title: Re: Can anyone upgrade CKeditor?
Post by: nibz on April 19, 2013, 04:38:08 PM
Thanks for the tip.

This works for the english .js file, but this doesn't work for the dutch (nl) file strange enough.
Maybe another plugin is causing is (also) causing the error.

Will try.. and if i find it i will let you know.
Title: Re: Can anyone upgrade CKeditor?
Post by: nibz on April 19, 2013, 04:48:37 PM
Firebug to the rescue ;)

There was a double ' in the wblink nl.js file after noNews

in /ckeditor/plugins/wblink/lang/nl.js change:
Code: [Select]
noNews: 'no news page selected''
to
Code: [Select]
noNews: 'no news page selected'
Title: Re: Can anyone upgrade CKeditor?
Post by: nibz on April 19, 2013, 06:17:02 PM
Attatched a new version.
Now it should work in any language.

[gelöscht durch Administrator]
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on April 20, 2013, 12:03:46 PM
THANKS again!

if somebody like colored skins for this ckeditor-version, see the attachment

unpak the files to modules / ckeditor / ckeditor / skins

and change the include.php in line 118 from
Code: [Select]
$ckeditor->config['skin'] = 'moono';
to
Code: [Select]
$ckeditor->config['skin'] = 'moonocolor';
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on April 29, 2013, 03:54:22 PM
Hi,

Quote from: info.php
*  version 4.1.0 130429
 *  + using cke 4.1.0 full
 *  + moonocolor skin as suggested by jacobi22 http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg175711.html#msg175711 (icons for wb plugins need redesign)
 *  ! fixed language problems as reported and solved by jacobi22 http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg175684.html#msg175684
 *    and nibz http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg175692.html#msg175692
 *  - deleted examples folder to keep file size a least bit smaller
 *  ! some more code cleaning, make toolbar selection work with wysiwyg-admin http://www.websitebakers.com/pages/admin/admin-tools/wysiwyg-admin.php
thanks for all the feedback and suggestions.

regards

Edith: find latest version below
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on April 30, 2013, 08:41:08 AM
Hi,

thank you very much for updating the CKE for WB. It looks good and works fine.

Edit: Sorry. The last version (130429) has a bug, it is not possible to save any links (neither internal, external nor e-mail-links). They are displayed, but after clicking on "save" (the icon in the toolbar or the button under the editor field, no difference) the link disappears. (At least with the newst Firefox, Windows 7, WB 2.8.3 Rev. 1638)

This problem does not exist in the older version (130419).

I've noticed you added an option to chose a news item in the link dialogue. That's a great idea.
Maybe it would be helpful if there was also an option to chose a "Topics" item?
(I had already a look at the php and js files of the plugin but did not manage to understand the js part.)

BR
_florian.
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on April 30, 2013, 07:39:48 PM
Hi,

thanks for testing, reporting and suggesting.
Edit: Sorry. The last version (130429) has a bug, it is not possible to save any links (neither internal, external nor e-mail-links). They are displayed, but after clicking on "save" (the icon in the toolbar or the button under the editor field, no difference) the link disappears. (At least with the newst Firefox, Windows 7, WB 2.8.3 Rev. 1638)
some would say it's not a bug it's a feature of cke 4.1 as described here (http://docs.ckeditor.com/#!/guide/dev_advanced_content_filter) and there (http://drupal.org/node/1936392). Disabled that as I belive this will cause more problems than gain of security. (..and btw I'm I bit too lazy to get into the details  8-) )
Quote
Maybe it would be helpful if there was also an option to chose a "Topics" item?
(I had already a look at the php and js files of the plugin but did not manage to understand the js part.)
tried that in the latest update by editing pages.php of the wbllink plugin, so understanding the js part is not too important in this case  :wink:.

Quote from: info.php
*  version 4.1.1 130430
 *  + using cke 4.1.1 full
 *  ! disabled Advanced Content Filter (ACF) to prevent filtering of wblinks
 *  ! excluded loading of link plugin becuase of double entiries in context menu, must be loaded for non WB Toolbars
 *  + topics pages are also selectable as wblink as requested by instantflorian http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg175956.html#msg175956

regards

Edith: find latest version below
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on April 30, 2013, 08:24:59 PM
hi marmot,

thanks for the extrawurst for me ;-)

Unfortunately, the link dialogue for Topics does not work yet, the select box stays empty. (See screenshot. "Politik" is a topics page)

BR
_florian
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on April 30, 2013, 08:28:34 PM
this version can only skin moono, right?
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on April 30, 2013, 08:34:51 PM
Quote
this version can only skin moono, right?
no
its works also with moonocolor
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on April 30, 2013, 08:39:04 PM
 :-D have tested all other skins except moonocolor
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on April 30, 2013, 08:52:29 PM
Hi,

Unfortunately, the link dialogue for Topics does not work yet, the select box stays empty. (See screenshot. "Politik" is a topics page)
sorry can't find anything wrong there. Still works for me. Maybe you got some admin and ftp acces to your installation for me, then I will try to find the problem? Which version of topics do you use? Can you set the links to items on a news page?
:-D have tested all other skins except moonocolor
be sure to use cke 4 skins or build one your own  :wink:.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on April 30, 2013, 09:44:39 PM
had upgraded and saw more skins.
now, after uninstall and reinstall, there are only 2 skins.  :wink:

but no button for link or wb-link or droplets. only unlink and anchor.
may i should not testing on wb 2.8.4.


sorry, my fault. there was a old folder wb_config in my template-directory.  :roll:
Title: Re: Can anyone upgrade CKeditor?
Post by: Stefek on May 01, 2013, 12:15:22 AM
Page Selection for Bakery Pages would be just great as well.

Thanks for the contribution.

Didn't test yet, but will so ASAP.

Kind regards,
Stefek
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on May 01, 2013, 08:47:41 AM
@marmot I tested it with Topics 0.71.3 and 0.71.5, WB 2.8.3.
News item selection works. Topic selection does not...

I'll send you a PM with access data to a test website.

TIA
_florian.
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on May 01, 2013, 10:02:56 AM
Hi,
Topic selection does not...
now it does. Didn't think about the several activity states of topics. Database query in pages.php was for active=1 now it is active>0. This will be fixed in next module update.
Btw: Didn't care about user right limitations so all topics (except unpublished ones) are listed in the dropdown box. Of course reading topics still depends on rights of the user.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on May 01, 2013, 01:49:39 PM
Thanks a lot. Now it works great.

The description "News Beitrag" / "News Item" should be changed just to "Beitrag" or "Entry". (I did that already in the ckeditor/plugins/wblink/lang/de.js for myself, whoohoo).
I think adding the possibility to select Bakery Items would be a good idea too.

BR
_florian.
Title: Re: Can anyone upgrade CKeditor?
Post by: Bug on May 03, 2013, 06:06:11 PM
it would be great if the Youtube plugin can be integrated again
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on May 04, 2013, 12:54:01 AM
Hi,

it would be great if the Youtube plugin can be integrated again
so what exactly is the problem? Tried that for you and it works fine. As you say "again" I can't remember a cke version which has had this plugin integrated, so which version do you mean?
Of course you have to use the right plugin for cke 4.x.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: Hans on May 04, 2013, 11:11:41 PM
Would be nice if one of the two versions could make it to the repository  :-P
There are so many helpful people here who post modules etc that are burried deep in the forum after a while. That's a shame imho.

Hope this **essential** plugin will have a better future ;-)

EDIT: "That's a shame": sorry, I wanted to say: "too bad"  :|.
Title: Re: Can anyone upgrade CKeditor?
Post by: Stefek on May 05, 2013, 01:33:11 AM
That's a shame imho.
I hear you.
+1
Title: Re: Can anyone upgrade CKeditor?
Post by: Bug on May 05, 2013, 02:40:59 AM
Hi,

it would be great if the Youtube plugin can be integrated again
so what exactly is the problem? Tried that for you and it works fine. As you say "again" I can't remember a cke version which has had this plugin integrated, so which version do you mean?
Of course you have to use the right plugin for cke 4.x.

regards

sorry I might be wrong than but i have an old version with the youtube plugin, do'nt know where I got it ...

let me rephrase my question,
can the youtube plugin be included in your (next) standard version
Title: Re: Can anyone upgrade CKeditor?
Post by: mikejd on May 23, 2013, 04:30:31 PM
Downloaded v 130430 and installed in WB v2.8.3. Works well. I needed the Magicline plugin and this is really useful for my site.

Only qualification - it would be nice to have the facility to upload images directly from the 'insert image' pop-up. This was available in CKEv3.5. Presumably it used CKFinder and this isn't now built in. I can still upload using 'Media' but it is handy to have the other facility.
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on May 23, 2013, 08:49:47 PM
Hi,

Just take the filemanager from the old WB CKE module.
it's still inside the package but disabled due to security. This was discussed several times for example here (http://www.WebsiteBaker.org/forum/index.php/topic,17981.msg159041.html#msg159041), where also is described how to enable the "upload" Tab by setting
Code: [Select]
$ckeditor->config['uploader'] = true; in include.php. If you want the upload button inside the file browser go to ckeditor\ckeditor\filemanager\browser\default\frmupload.html.org and rename to frmupload.html .
But once again think of possible security problems.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: Vlob on May 25, 2013, 10:08:04 AM
I think i am too stupid, can anyone help me in adding a toutube / social media addon to the new ck editor

Everytime i try the whole thing breaks down...

 :?
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on May 25, 2013, 11:26:45 AM
Hi,

can anyone help me in adding a toutube / social media addon to the new ck editor
not sure which plugin you mean so I took oEmbed for my example:

Quote
- select the plugin from the plugins page (http://ckeditor.com/addons/plugins/all) and check the cke version it is built for
- download the plugin from the download link (http://download.ckeditor.com/oembed/releases/oembed_1.09.zip)
- extract the zip
- copy extracted folder to the plugins directory of cke
- in include.php around line 212 add your plugin to $ckeditor->config['extraPlugins'] (this tells cke to load the new plugin)
- in /wb_config/wb_ckconfig.js add the button for the plugin to the active Toolbar. Without having wysiwyg Admin tool installed the default toobar is WB_Default(see around line 111). In this case you can add the button in aroud line 99 after 'iframe' by just adding ",'oembed'": (this tells cke to show a button for the new plugin)
Code: [Select]
{ name: 'insert', items : [ 'Image','Flash','Table','HorizontalRule','Smiley','SpecialChar','Iframe','oembed' ] },
If you are not able to find the files and the directory have a break and try again next day.  :wink:

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on May 25, 2013, 11:40:25 AM
Quote
in /wb_config/wb_ckconfig.js add the button for the plugin to the active Toolbar.
add the button in Toolbar WB_DEFAULT and WB_Full, but it works only in the toolbar WB_Full - why??  i dont know

now i use WB_Full as my default toolbar
(line 173 / 174 in wb_config.js
// The default toolbar. Default: WB_DEFAULT
  config.toolbar = 'WB_Full';
)

another tip:  dont use spaces between the plugins in include.php

this works
Code: [Select]
$ckeditor->config['extraPlugins'] = 'syntaxhighlight,codemirror,wblink,wbdroplets,shybutton,youtube';
no editor loaded (see space between shybutton and youtube)
Code: [Select]
$ckeditor->config['extraPlugins'] = 'syntaxhighlight,codemirror,wblink,wbdroplets,shybutton, youtube';
Title: Re: Can anyone upgrade CKeditor?
Post by: Bug on May 28, 2013, 11:46:37 AM
tthhaannkkxx
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on June 18, 2013, 11:23:23 PM
Hi,

updated to cke 4.1.2.
Quote from: info.php
*  version 4.1.2 130616
 *  + using cke 4.1.2 full
 *  + added youtube plugin as requested by Bug: http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg176059.html#msg176059
 *  + added oembed plugin

regards

[gelöscht durch Administrator]
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on June 19, 2013, 08:38:18 AM
Hi,
thanks for the new version.

What's the reason that even the brand new upcoming WB 2.8.4 is still delivered with FCK as default editor and not CKE?

BR
_florian.
Title: Re: Can anyone upgrade CKeditor?
Post by: easyuser on June 19, 2013, 10:07:11 AM
Hi,
updated to cke 4.1.2.
regards
Thanks for the upgrade - but in 2.8.3 Rev. 1927 CKEditor does not work - it just displays the "naked" textfield.
In Firefox and IE10.

Here ist the Browser sourcecode:

Code: [Select]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<title>Enter your website title - Verwaltung - Seiten</title>
<meta http-equiv="content-type" content="text/html; charset=utf-8" />
<meta http-equiv="content-language" content="DE" />
<meta name="description" content="Verwaltung" />
<meta name="keywords" content="Verwaltung" />
<meta name="author" content="WebsiteBaker Org e.V." />
<meta http-equiv="Content-Encoding" content="gzip" />
<meta http-equiv="Accept-Encoding" content="gzip, deflate" />
<meta http-equiv="expires" content="0" />
<meta http-equiv="cache-control" content="no-cache" />
<meta http-equiv="pragma" content="no-cache" />
<link href="http://localhost:8080/xampp/www/wb284/templates/wb_theme/css/screen.css" rel="stylesheet" type="text/css" />

<script type="text/javascript">
var WB_URL = 'http://localhost:8080/xampp/www/wb284';
var THEME_URL = 'http://localhost:8080/xampp/www/wb284/templates/wb_theme';
var ADMIN_URL = 'http://localhost:8080/xampp/www/wb284/administrator';
var LANGUAGE = 'DE';
</script>
<script type="text/javascript">
function confirm_link(message, url) {
if(confirm(message)) location.href = url;
}
</script>
<script src="http://localhost:8080/xampp/www/wb284/include/jquery/jquery-min.js" type="text/javascript"></script>
<script src="http://localhost:8080/xampp/www/wb284/include/jquery/jquery-insert.js" type="text/javascript"></script>
<script src="http://localhost:8080/xampp/www/wb284/include/jquery/jquery-include.js" type="text/javascript"></script>
<!--[if lt IE 7]><script type="text/javascript" src="http://localhost:8080/xampp/www/wb284/include/jquery/plugins/jquery-pngFix.js"></script><![endif]-->
<script src="http://localhost:8080/xampp/www/wb284/templates/wb_theme/jquery/jquery-plugins.js" type="text/javascript"></script>

</head>
<body lang="DE" >
<div id="overDiv" style="position:absolute; visibility:hidden; z-index:1000;"></div>
<div class="main">

<table class="header layout">
<tr>
<td class="logo">
<a href="http://localhost:8080/xampp/www/wb284/administrator" title="Start"><img src="http://localhost:8080/xampp/www/wb284/templates/wb_theme/images/logo.png" alt="Logo" /></a>
</td>
<td></td>
<td class="topnav ">
<span><a href="http://localhost:8080/xampp/www/wb284/administrator" title="Start"><img src="http://localhost:8080/xampp/www/wb284/templates/wb_theme/images/home.png" alt="Start" /></a></span>
<a href="http://localhost:8080/xampp/www/wb284/pages/servus.php" target="_blank" title="Webseite"><img src="http://localhost:8080/xampp/www/wb284/templates/wb_theme/images/view.png" alt="http://localhost:8080/xampp/www/wb284" /></a>
<a href="http://www.WebsiteBaker.org/de/hilfe.php" target="_blank" title="WebsiteBaker Hilfe"><img src="http://localhost:8080/xampp/www/wb284/templates/wb_theme/images/help.png" alt="WebsiteBaker Hilfe" /></a>
        <a href="http://localhost:8080/xampp/www/wb284/administrator/settings/locking.php" title="Wartung an"><img src="http://localhost:8080/xampp/www/wb284/templates/wb_theme/images/unlock.png" alt="Wartung an" title="Wartung an" /></a>
&nbsp;<a href="http://localhost:8080/xampp/www/wb284/administrator/logout/index.php" title="Abmelden"><img src="http://localhost:8080/xampp/www/wb284/templates/wb_theme/images/logout.png" alt="Abmelden" /></a>
</td>
<td class="version ">
Version 2.8.3 <br />
    Revision 1925
</td>
</tr>
</table>

<div class="table rounded shadow">

<div class="hmenu ">
<ul>
<li class="pages current"><a class="pages current" href="http://localhost:8080/xampp/www/wb284/administrator/pages/index.php">Seiten</a></li>
<li class="media"><a class="media" href="http://localhost:8080/xampp/www/wb284/administrator/media/index.php">Medien</a></li>
<li class="addons"><a class="addons" href="http://localhost:8080/xampp/www/wb284/administrator/addons/index.php">Erweiterungen</a></li>
<li class="preferences"><a class="preferences" href="http://localhost:8080/xampp/www/wb284/administrator/preferences/index.php">Einstellungen</a></li>
<li class="settings"><a class="settings" href="http://localhost:8080/xampp/www/wb284/administrator/settings/index.php">Optionen</a></li>
<li class="admintools"><a class="admintools" href="http://localhost:8080/xampp/www/wb284/administrator/admintools/index.php">Admin-Tools</a></li>
<li class="access"><a class="access" href="http://localhost:8080/xampp/www/wb284/administrator/access/index.php">Benutzerverwaltung</a></li>
<li>&nbsp;</li>
</ul>
</div>

<div class="td">
<div class="content">

<div class="page-info">
<table>
<thead>
  <tr>
    <th class="description"></th>
    <th class="id"></th>
    <th></th>
  </tr>
</thead>
<tbody>
  <tr>
<td class="left nowrap"><h2>Seite &auml;ndern</h2></td>
<td class="left">PID: 2</td>
<td class="right nowrap">
Aktuelle Seite:<strong>servus</strong><br />
        <a href="http://localhost:8080/xampp/www/wb284/administrator/pages/settings.php?page_id=2">Einstellungen &auml;ndern</a>
<span class="link">
-
        <a href="http://localhost:8080/xampp/www/wb284/administrator/pages/sections.php?page_id=2">Abschnitte verwalten</a>
</span>
<br />
<span class="right ">
zuletzt ge&auml;ndert von Administrator, 09:04 AM, 2013-06-19
</span>
</td>

  </tr>
</tbody>
</table>
</div>
<div class="section-info" id="section_2" ><b>Block: </b>Hauptblock<b>  Modul: </b>wysiwyg <b>  ID: </b>2</div>
<form name="wysiwyg2" action="http://localhost:8080/xampp/www/wb284/modules/wysiwyg/save.php" method="post">
<input type="hidden" name="page_id" value="2" />
<input type="hidden" name="section_id" value="2" />
<input type="hidden" name="ac3966cac0baa981" value="30c3966cac0baa98" title="" alt="" />



<textarea name="content2" rows="8" cols="80">test</textarea>
<script type="text/javascript">//<![CDATA[
window.CKEDITOR_BASEPATH='/xampp/www/wb284/modules/ckeditor/ckeditor/';
//]]></script>
<script type="text/javascript" src="/xampp/www/wb284/modules/ckeditor/ckeditor/ckeditor.js?t=B8DJ5M3"></script>
<script type="text/javascript">//<![CDATA[
CKEDITOR.replace('content2',
 {"ModulVersion":"4.1.2","format_tags":"p;div;h1;h2;h3;h4;h5;h6;pre;address","skin":"moono","language":"de","defaultLanguage":"en","resize_dir":"vertical","autoParagraph":true,"contentsCss":"http:\/\/localhost:8080\/xampp\/www\/wb284\/templates\/round\/editor.css","stylesSet":"wb:http:\/\/localhost:8080\/xampp\/www\/wb284\/modules\/ckeditor\/wb_config\/editor.styles.js","templates_files":["http:\/\/localhost:8080\/xampp\/www\/wb284\/modules\/ckeditor\/wb_config\/editor.templates.js"],"customConfig":"http:\/\/localhost:8080\/xampp\/www\/wb284\/modules\/ckeditor\/wb_config\/wb_ckconfig.js","filebrowserBrowseUrl":"\/xampp\/www\/wb284\/modules\/ckeditor\/ckeditor\/filemanager\/browser\/default\/browser.html?Connector=\/xampp\/www\/wb284\/modules\/ckeditor\/ckeditor\/filemanager\/connectors\/php\/connector.php","filebrowserImageBrowseUrl":"\/xampp\/www\/wb284\/modules\/ckeditor\/ckeditor\/filemanager\/browser\/default\/browser.html?Type=Image&Connector=\/xampp\/www\/wb284\/modules\/ckeditor\/ckeditor\/filemanager\/connectors\/php\/connector.php","filebrowserFlashBrowseUrl":"\/xampp\/www\/wb284\/modules\/ckeditor\/ckeditor\/filemanager\/browser\/default\/browser.html?Type=Flash&Connector=\/xampp\/www\/wb284\/modules\/ckeditor\/ckeditor\/filemanager\/connectors\/php\/connector.php","uploader":false,"extraPlugins":"syntaxhighlight,codemirror,wblink,wbdroplets,shybutton,youtube,oembed","removePlugins":"wsc,link","browserContextMenuOnCtrl":true,"scayt_sLang":"de_DE","scayt_autoStartup":false,"height":"350","width":"100%"});
//]]></script>



<table summary="" cellpadding="0" cellspacing="0" border="0" width="100%" style="padding-bottom: 10px;">
<tr>
<td align="left">
<input type="submit" value="Speichern" style="width: 100px; margin-top: 5px;" />
</td>
<td align="right">
<input type="button" value="Abbrechen" onclick="javascript: window.location = 'index.php';" style="width: 100px; margin-top: 5px;" />
</td>
</tr>
</table>
</form>
<br />
</div>
</div>
</div>

<table class="footer">
<tbody>
<tr>
<td>
      <!-- Please note: the below reference to the GNU GPL should not be removed, as it provides a link for users to read about warranty, etc. -->
      <a href="http://www.websitebaker2.org/" title="external">WebsiteBaker</a> is released under the
      <a href="http://www.gnu.org/licenses/gpl.html" title="WebsiteBaker is released under the GNU General Public License">GNU General Public License</a>
      <!-- Please note: the above reference to the GNU GPL should not be removed, as it provides a link for users to read about warranty, etc. -->
</td>
</tr>
</tbody>
</table>
</div>

</body>
</html>

Hi,
thanks for the new version.

What's the reason that even the brand new upcoming WB 2.8.4 is still delivered with FCK as default editor and not CKE?

BR
_florian.
Nobody knows. Somebody said, FCKEditor is working better than CKEditor.  8-)
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on June 19, 2013, 10:29:40 AM
Quote
Thanks for the upgrade - but in 2.8.3 Rev. 1927 CKEditor does not work - it just displays the "naked" textfield.
In Firefox and IE10.

Can't confirm. Just installed a fresh Rev. 1927 and it works. Maybe you didn't select the CKEditor in advanced options?
Title: Re: Can anyone upgrade CKeditor?
Post by: easyuser on June 19, 2013, 12:01:48 PM
Quote
Thanks for the upgrade - but in 2.8.3 Rev. 1927 CKEditor does not work - it just displays the "naked" textfield.
In Firefox and IE10.

Can't confirm. Just installed a fresh Rev. 1927 and it works. Maybe you didn't select the CKEditor in advanced options?
I selected CKEditor. If I didn't, there wouldn't be "CKEditor-Javascript Code" in browser HTML-sourcecode.
Perhaps the use of localhost:8080 (not Standard 80-port) and the use of "\administrator" instead of standard "\admin" adminfolder could be a problem. FCKEditor works.

Edit:
There is some weird problem: Also CKEditor0.76 from addons repository doesn't work.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on June 19, 2013, 01:21:03 PM
Quote
There is some weird problem: Also CKEditor0.76 from addons repository doesn't work.

do you use a wb_ckconfig.js in your template directory? if "yes", rename the file (like wb_ckconfig_bak.js) , clear the browser-cache and try again
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on June 19, 2013, 08:19:02 PM
Hi,

Thanks for the upgrade - but in 2.8.3 Rev. 1927 CKEditor does not work - it just displays the "naked" textfield.
In Firefox and IE10.
thanks for testing and reporting. To be honest I am not ready to give any support for the svn versions of wb as the developers always say that there can be errors (I'm rather sure in the release there won't  :wink:) and how much very smart programming happens in the backround which is not seen in svn. So I can wait for wb 2.8.4 which is surely coming very soon. But once again, I appreciate your report!
FCK is neither developed nor supported anymore, but as it just works
not official but there are updates (http://www.WebsiteBaker.org/forum/index.php/topic,25930.msg177128.html#msg177128) but no feedback ;).

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: easyuser on June 19, 2013, 10:10:40 PM
On a fresh installation of WB2.8.4 SVN it works smooth... I think a previous installation of Ralf's extendedWYSIWYG -  module in the other testsystem where CKEditor didn't work changed too much in the system.
Title: Re: Can anyone upgrade CKeditor?
Post by: badknight on July 03, 2013, 02:54:27 PM
works great thanks..

if someone needs width="" and height="" instead of style="width:[...]

open the file -> /modules/ckeditor/ckeditor/plugins/images/dialog/images.js
decompress the file
~Line 287
change the code to
Code: [Select]
a == f ? (c ? b.setAttribute("width", CKEDITOR.tools.cssLength(c)) : b.removeAttribute("width"), !d && b.removeStyle("width")) : 4 == a ? c.match(k) ? b.setAttribute("width", CKEDITOR.tools.cssLength(c)) : (a = this.getDialog().originalElement, "true" == a.getCustomData("isReady") && b.setAttribute("width", a.$.width)) : 8 == a && (b.removeAttribute("width"), b.removeStyle("width"))

and ~Line 306
Code: [Select]
a == f ? (c ? b.setAttribute("height", CKEDITOR.tools.cssLength(c)) : b.removeAttribute("height"), !d && b.removeStyle("height")) : 4 == a ? c.match(k) ? b.setAttribute("height", CKEDITOR.tools.cssLength(c)) : (a = this.getDialog().originalElement, "true" == a.getCustomData("isReady") && b.setAttribute("height", a.$.height)) : 8 == a && (b.removeAttribute("height"), b.removeStyle("height"))
i just replaced the setStyle to setAttribute .. it's a quick & dirty code but it works ;)
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on July 25, 2013, 10:30:50 PM
Hi,

once again here is another cke update. Maybe someone finds the new backup and wbsave plugin useful.

Quote from: info.php
*  version 4.2.0 130724
 *  + using cke 4.2.0 full
 *  ! changed wb default toolbar for better overview and to avoid double source button
 *  ! updated codemirror plugin to v. 1.06
 *  + added patched/extended version of backup plugin using local browser storage
 *  ! replaced editor save plugin by wbsave which saves without page reload

regards

Edith: Find IE10 fixed version below.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on July 26, 2013, 12:00:12 AM
Quote
once again here is another cke update. Maybe someone finds the new backup and wbsave plugin useful.

Maybe? i'm sure - i think, its very useful!!
Thanks for your work

one question...
where did the ckeditor save the backup-versions? i found nothing in the data base
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on July 26, 2013, 12:20:55 AM
where did the ckeditor save the backup-versions? i found nothing in the data base
Quote from: info.php
*  + added patched/extended version of backup plugin using local browser storage
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on July 26, 2013, 07:42:06 AM
Hi, tested in Rev 1932.

What is the right way for using the backup-function?
What is the different between button wbSave in the toolbar and button Save under the editor.

In Firefox i saw 1x something like ajax-saving. After that all wbSave-clicks have a page-reload.
In Chrome every wbSave have ajax.

Can backup active as defauld or make this a performance problem?

For my first try i found the function not easy to find, to use, to understand.
But the idea is very good and thanks for adding the function.
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on July 26, 2013, 04:03:59 PM
Hi

puh that's a lot.
Hi, tested in Rev 1932.
thanks for taking your time
Quote
What is the right way for using the backup-function?
push the backup button to activate, push again to turn off  :wink:
Quote
What is the different between button wbSave in the toolbar and button Save under the editor.
as mentioned in info.php wbsave does not reload the page, the save button does
Quote
In Firefox i saw 1x something like ajax-saving. After that all wbSave-clicks have a page-reload.
In Chrome every wbSave have ajax.
would be a wonder it ajax is used for saving by this plugin as no ajax is implemented. I left the uncompressed source inside so you can see it yourself. Maybe you are mixing up something with this (http://www.WebsiteBaker.org/forum/index.php/topic,26095.msg178347.html#msg178347)? I can't see the behavior you reported in wb 283 rev 1638 and FF 22. As you are an experienced wb tester you surely know that it is a good idea to use a clean installation for testing and it's also a good idea to tell about the testing evironment when reporting errors.  :wink:
Quote
Can backup active as defauld or make this a performance problem?
inside wb_ckconfig.js you can define
Code: [Select]
config.backup_on_start = true;
config.backup_save_delay = xxxx;
for activating backup on start and for setting the delay time in ms for auto strorage. I didn't notice performance problems but maybe the browser storage gets full sometimes. So simply test yourself if you can use this for your purposes or not.
Quote
For my first try i found the function not easy to find, to use, to understand.
So now you found and tested you know about it and can explain it to your customers showing them what an expert you are.  :wink:

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on July 26, 2013, 04:51:16 PM
Hi,

Quote
push the backup button to activate, push again to turn off
In my FF it works yesterday not expected. Thats why i ask for the right way.
- find and push button backup
- find and push button wbSave instead save
- find the backups bottom right

Quote
would be a wonder it ajax is used for saving by this plugin as no ajax is implemented
I wrote "something like ajax" and should mean "without page-reload". It's a clean Installation, nothing was mixed up.
After testing today in FF it works like it should. So it is easier to understand and easier to use.

Thanks for your work.

Maybe i will change the theme, the amount of backups (if this is possible) and the button-positions. Than the users can test it. But i don't really like the local browser storage.
Title: Re: Can anyone upgrade CKeditor?
Post by: Argos on August 01, 2013, 12:04:04 AM
I just installed CKeditor 4.2, and I think it's great. It would be best to have skin "Monoo Color" as default however, I think most users find the all-blue Monoo skin not user friendly.

I have a problem with the image function though: in IE10 I cannot browse for files. The browser window shows no files, only a folder icon. There is nothing to do, excpet closing the window again. I do have files in the Media folder, but they don't show up in the editor. The function works fine in FireFox though.
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on August 01, 2013, 09:16:41 PM
Hi,

It would be best to have skin "Monoo Color" as default however, I think most users find the all-blue Monoo skin not user friendly.
I don't think so and it seems the cke Team doesn't either. I think if someone has problems using the edtior depending from the skin, she/ he should go on and look for an other hobby :wink:  But you can install wysiwyg-admin (http://www.websitebakers.com/pages/admin/admin-tools/wysiwyg-admin.php) and than can easy decide which skin to use and honor my painful work to adapt the monoo-color skin to the wb toolbar. :-)
Quote
I have a problem with the image function though: in IE10 I cannot browse for files.
thanks for testing and reporting. Seems cke users do not use IE10 as this problem occurs in all versions of the cke module. I append a fixed version.

BTW: This fix is applied to FCK (http://www.WebsiteBaker.org/forum/index.php/topic,25930.msg177128.html#msg177128) sice some time. (I'm writing this cause it might help you for another problem you, and some users before you, did report about FCK)

regards

Edith: find updated version below.
Title: Re: Can anyone upgrade CKeditor?
Post by: Argos on August 01, 2013, 10:56:53 PM
OK, apparently there are people who like monochrome interfaces with indistinctable icons  :-D
But more than 22000 downloads of the colored version says something as well...
Anyway, never mind. I just changed the skin in the include.php, no prob.

Your new version doesn't solve the missing images problem by the way. Or should I uninstall first?
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on August 01, 2013, 11:02:30 PM
Quote
Or should I uninstall first?

its the best way - and after that - clear the cache
no problems here in IE10 and the image browser in the ckeditor
Title: Re: Can anyone upgrade CKeditor?
Post by: Argos on August 01, 2013, 11:37:10 PM
You're right, deinstall, clear browser cache, close and restart browser did the trick. Now it works fine. Thanks!  :-D
Title: Re: Can anyone upgrade CKeditor?
Post by: daydreamer on August 08, 2013, 12:42:55 PM
Browse image upload button not showing when inserting image from editor
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on August 08, 2013, 06:16:22 PM
Hi,

Could anyone upgrade ckeditor to version 4.0.1 looks awesome and new features  :-D
so at the beginning this was your whish I fullfilled after some others disussed how difficult it would be. Now, after more than 6 months, you come up with this statement
Browse image upload button not showing when inserting image from editor
No wb version, no browser version, no example link not even a hello.
So let me say thank you for your gerat contibutions where we all can participate!

BTW: the upload stuff was disabled years ago for security reasons in fck and cke, and yes - there is a serach field in this forum and I think this question has been asked several times, even right here (http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg176502.html#msg176502) in this thread. But I completely understand that no one may demand form you to read the thread you started.  :wink:

Don't get me wrong I don't want to offend you but simply want to show you my point of view and I'm doing it my way :-D.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on August 19, 2013, 09:18:41 AM
Hi,

@marmot: Thank you again for updating the cke module.
With the Argos Backend in Firefox (WB 2.8.3 Rev. 1611) there's a small bug - at least I think it's a bug: when switching to full screen mode and then using the source code view, alle rows are shown centered. I don't think this makes it easier to edit the source code ;-)
 
This does not happen in the normal, small view. Do you have any idea how to fix this?

BR
-florian.

Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on August 19, 2013, 09:43:43 AM
take a look to the screen.css in the argos_theme_folder at line 4 and deactivate the entry
text-align :center; in this line 4

Code: [Select]
body { background :url(../images/background.jpg) #f9f9f9 0 0 repeat-x; margin :0; text-align :center; }
and the same in line 25

Code: [Select]
#content_container { text-align :center; width :948px; clear :both; margin :0 auto; }
the argos_theme doesn't need this entrys
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on August 19, 2013, 10:00:33 AM
Thanks for the hint.
 In my version it was in line 23 (#content_container) of the theme.css. Now it's fixed.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on August 22, 2013, 07:18:06 PM
I seem to be unable to make an editor.css work with this module. For testing, I just added a class to the editor.css of template 'round', but it is not showing up in the styles combo.

it works for me, if i have only one editor.css in the system. i rename the editor.css in the folder modules/ckeditor/wb_config and copy the style from there to my editor.css in the template folder
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on August 22, 2013, 07:53:44 PM
Hi,

afaik the editor.css is just meant to style the text input field in backend so that it looks like the text in the frontend, e.g. background color, font and link color, font size and style. So if you create an editor.css with blue background and yellow font color the ckeditor textfield should be coloured this way.

To add styles or templates to the combo boxes you have to create the editor.styles.js and editor.templates.js in your template directory.

At least that's the way I understand the readme_faq.txt in ckeditor/wb_config. Never tested this for myself.   

BR
_florian.
Title: Re: Can anyone upgrade CKeditor?
Post by: mr-fan on August 23, 2013, 06:25:22 AM
I seem to be unable to make an editor.css work with this module. For testing, I just added a class to the editor.css of template 'round', but it is not showing up in the styles combo.

like florian said

styles combo -> editor.styles.js
templates button -> editor.templates.js
look&feel of the inputfield ->editor.css

all works

regards mr-fan
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on October 02, 2013, 10:18:10 PM
Hi,

Quote from: info.php
*  version 4.2.1 131001
 *  + using cke 4.2.1 full
 *  ! message bug in backup plugin
 *  ! updated youtube plugin to v. 1.0.7

regards

Edith: find latest version below
Title: Re: Can anyone upgrade CKeditor?
Post by: Hans on October 02, 2013, 11:18:39 PM
Thanks Marmot! Hope the Module Repo will be updated with this one.
Hans
Title: Re: Can anyone upgrade CKeditor?
Post by: daydreamer on October 17, 2013, 03:19:19 PM
Awesome thanks :D
Title: Re: Can anyone upgrade CKeditor?
Post by: nibz on October 17, 2013, 03:36:53 PM
Thanks Marmot! Hope the Module Repo will be updated with this one.
Hans

I updated the repo with the new version.
Thanks to marmot for updating the file :)
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on October 17, 2013, 07:27:04 PM
one (big) problem with the Vers 4.2.1 131001, but only on my locale testarea (it works fine, if i use the CKEditor on my Webspace)

i try it in english..
if i change the Wysiwyg-Editor in Advanced Settings from FCK to CKEditor, i can work with the CKEditor, no problems, everything works
if i close the browser, clean the cache and start again, it looks like a deinstalled Wysiwyg-Editor, only a textarea with the source code from this section

i try it with Firefox 25, IE 10 and Chrome, the same problem in all browsers

if i look into the source code from the backend page, i found this


Code: [Select]
<script type="text/javascript">//<![CDATA[
window.CKEDITOR_BASEPATH='G:/cms/wb_test_1930/modules/ckeditor/ckeditor/';
//]]></script>
<script type="text/javascript" src="G:/cms/wb_test_1930/modules/ckeditor/ckeditor/ckeditor.js?t=B8DJ5M3"></script>

is it possible, that i have a locale problem with the CKEDITOR_BASEPATH?

WB_URL for this project is http://cms/wb_test_1930/


cleared with the update to the next version
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on October 24, 2013, 11:00:37 PM
Hi,

Quote from: info.php
*  version 4.2.2 131024
 *  + using cke 4.2.2 full
 *  ! updated moonocolor skin to v 1.1 (1.2 didn't work for some reasons)

regards

Edith: new version below
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on October 24, 2013, 11:44:03 PM
Works very good for me, no problems - THANKS again

P.S.: for the next version - i found some write errors in

ckeditor/ckeditor/plugins/codemirror/lang/de.js

Auskommentierung entferen -> Auskommentierung entfernen

ckeditor/ckeditor/lang/de.js  (in the first lines)

Alle nicht gespeicherten Änderungen gehen verlohren -> Alle nicht gespeicherten Änderungen gehen verloren
Title: Re: Can anyone upgrade CKeditor?
Post by: ruebenwurzel on October 25, 2013, 06:51:19 AM
Hallo,

nachdem ich ja seit kurzer Zeit auch ein Freund des CKEditor bin, auch von meiner Seite Daumen hoch. Scheint alles zu funktionieren (hab aber auch noch nicht alles gestestet).

Auf jeden Fall mal vielen Dank an marmot für die tolle Arbeit.

Gruß
Matthias
Title: Re: Can anyone upgrade CKeditor?
Post by: nibz on October 25, 2013, 06:09:45 PM
Hi,

Quote from: info.php
*  version 4.2.2 131024
 *  + using cke 4.2.2 full
 *  ! updated moonocolor skin to v 1.1 (1.2 didn't work for some reasons)

regards

Thanks for the great work Marmot!
I updated the module repo again! :)
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on November 21, 2013, 09:09:33 PM
Hi,

here we go....

Quote
*  version 4.3.0 131120
 *  + using cke 4.3.0 full
 *  ! wblink plugin can address news page without selecting a news item
 *  ! fixed problem in wb droplets plugin

regards

Edith: find updated version below
Title: Re: Can anyone upgrade CKeditor?
Post by: ruebenwurzel on November 23, 2013, 11:28:37 AM
Hello marmot,

great work. I love CKEditor more and more. Works without any problems.

Matthias
Title: Re: Can anyone upgrade CKeditor?
Post by: N1kko on November 23, 2013, 03:49:15 PM
Thanks marmot  :-D
Title: Re: Can anyone upgrade CKeditor?
Post by: nibz on December 02, 2013, 12:10:35 AM
Hi,

here we go....

Quote
*  version 4.3.0 131120
 *  + using cke 4.3.0 full
 *  ! wblink plugin can address news page without selecting a news item
 *  ! fixed problem in wb droplets plugin

regards

Updated the addons repo
Title: Re: Can anyone upgrade CKeditor?
Post by: Yetiie on December 03, 2013, 10:14:17 AM
Thx for updating the CKE and uploading it to the respository too.
Great Job :-)
Title: Re: Can anyone upgrade CKeditor?
Post by: Argos on December 03, 2013, 01:55:50 PM
I tried the 4.30 version and it seems that the link insert function fails. When I click on the icon to insert a link, the screen goes transparent white, like the background for a lightbox, but that's all. No lightbox or popup appears, and actually WB freezes. You have to remove the last part of the url to access the admin again.

Can anyone confirm this? I tried the latest versions of IE, Chrome and Firefox. I must admit I run WP 2.8.1 on that site, so maybe it works on WB 2.8.3. I will try that on another site. But 2.8.1 is not really obsolete or something, so you would expect it to work fine.

===========

OK, I tried it on 2.8.3 as well. Now the popup appears, but it doesn't work in IE11. Firefox and Chrome are allright, but in IE11 the buttons are not working, and also the hidden, dynamic parts of the popup are visible. So you see the insert email link part of the popup right away, even if you don't choose to do so.

So all in all, the module is rather picky right now.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on December 05, 2013, 08:35:22 PM
extension for internal links to bakery-product-pages in the (wb)Link-dialog of ckeditor Vers 4.30 from marmot
(build a list with all product- or item-pages from the bakery-shop, if you select "wblink" in the link-dialog)
works in ckeditor 4.3 for news- and topic-pages

File: modules/ckeditor/ckeditor/plugins/wblink/pages.php

change this line
Code: [Select]
echo $NewsItemsSelectBox;
with this code
Code: [Select]
//Bakery_Items
$bakerySections = $database->query("SELECT * FROM ".TABLE_PREFIX."sections WHERE module = 'bakery'");
while($section = $bakerySections->fetchRow()){
        $bakery = $database->query("SELECT title, link FROM ".TABLE_PREFIX."mod_bakery_items WHERE active=1 AND section_id = ".$section['section_id']);
        $NewsItemsSelectBox .= "NewsItemsSelectBox[".$section['page_id']."] = new Array();";
        while($item = $bakery->fetchRow()) {
                $NewsItemsSelectBox .= "NewsItemsSelectBox[".$section['page_id']."][NewsItemsSelectBox[".$section['page_id']."].length] = new Array('".$item['title']."', '".WB_URL.PAGES_DIRECTORY.$item['link'].PAGE_EXTENSION."');";
        }
}

echo $NewsItemsSelectBox;

for use in Link-dialog

choose WB-Link in Link-Type
choose your Bakery-Main-Page (Overview) in WB-Page
select your item in NEWS-Item
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on December 12, 2013, 09:02:15 PM
Hi,

Can anyone confirm this? I tried the latest versions of IE, Chrome and Firefox. I must admit I run WP 2.8.1 on that site, so maybe it works on WB 2.8.3. I will try that on another site. But 2.8.1 is not really obsolete or something, so you would expect it to work fine.
can't confirm. It seems WB team doesn't even support version 283 anymore. As an experienced user you surely read the modules deails where you can find that this module is designed for wb 283. Nevertheless I tried it on wb281 for you and it worked without issues.
Quote
OK, I tried it on 2.8.3 as well. Now the popup appears, but it doesn't work in IE11. Firefox and Chrome are allright, but in IE11 the buttons are not working, and also the hidden, dynamic parts of the popup are visible. So you see the insert email link part of the popup right away, even if you don't choose to do so.
can't confirm, maybe some browser cache stuff. But maybe the new version works better for you. On the other hand just wait for the much better version of this module patched by the wb team which surerly is perfect just like wb284 for which the new version is designed.
Quote
So all in all, the module is rather picky right now.
sometimes I can't help but to think some forum users are so too ;)

Quote from: info.php
*  version 4.3.1 131211
 *  + using cke 4.3.1 full
 *  ! again fixed problem in wb droplets plugin
 *  ! fixed problem in wb link plugin
 *  + bakery items are selectable as wb link, thanks to jacoby22: http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg181817.html#msg181817
 *   ! wb link plugin: items select is only shown when a news, topis or bakery page is selected

regards

Edith: find latest version below
Title: Re: Can anyone upgrade CKeditor?
Post by: Argos on December 15, 2013, 12:10:11 AM
Hm.. doesn't work either. I do get a popup now, but it doesn't create links. The droplet function doesn't work either, nor does other settings. I tried several WB 283 installs, but CKE fails on all installs somehow. Maybe it has something to do with some server setting, I don't know.
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on December 15, 2013, 10:22:27 AM
Hi,

Maybe it has something to do with some server setting, I don't know.
I don't know too. Surely I'm interested in solving this issue but to find out what is going on I would need an admin and ftp account on one of your (test) sites.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on December 15, 2013, 10:39:53 AM
i found a message in another thread, that some people has problems with the cke 4.x in older jquery-versions. can that be the problem?
Title: Re: Can anyone upgrade CKeditor?
Post by: Argos on December 16, 2013, 12:24:08 PM
Yes, that could be. I will check that out. This weekend I found that the latest module works fine on a WB 2.8.1 install. So the must be some conflict somewhere, and that could very well be a jquery one.
Title: Re: Can anyone upgrade CKeditor?
Post by: nibz on December 17, 2013, 09:25:54 PM

Quote from: info.php
*  version 4.3.1 131211
 *  + using cke 4.3.1 full
 *  ! again fixed problem in wb droplets plugin
 *  ! fixed problem in wb link plugin
 *  + bakery items are selectable as wb link, thanks to jacoby22: http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg181817.html#msg181817
 *   ! wb link plugin: items select is only shown when a news, topis or bakery page is selected


Updated the addonsrepo with this file :)
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on December 19, 2013, 08:09:53 PM
Hi,

Quote from: info.php
*  version 4.3.1.1 131219
 *  ! editor was not attached to textarea named "description", reported by bsdzilla: http://www.WebsiteBaker.org/forum/index.php/topic,17913.msg182267.html#msg182267

regards

Edith: find update below
Title: Re: Can anyone upgrade CKeditor?
Post by: Argos on January 07, 2014, 07:29:01 PM
The "browse on server" function (images, files) doesn't work out of the box.
Title: Re: Can anyone upgrade CKeditor?
Post by: cwsoft on January 07, 2014, 08:45:25 PM
Hi,

Quote from: argos
The "browse on server" function (images, files) doesn't work out of the box.
Maybe this has to do with an error in the media handling of latest WB 2.8.4 REV 2082.

Just tried a clean install on Windows testserver with PHP 5.4.19 and Firefox 26.0, but I can't upload images like jpg from the WB 2.8.4 media folder at all. Always got the error message file already exists (but there is no file available). Activating the "overwrite file during upload" doesn't work either.

False positive: For details read this post (http://www.WebsiteBaker.org/forum/index.php/topic,26696.msg183237.html#msg183237)

The "browse on server" feature works out of the box with Marmots CKEditor version v4.3.1.1 below including image upload etc. Tested on Windows server with PHP 5.4.19, WB 2.8.4 REV 2082 and Firefox 26 - both admin themes.

Cheers cwsoft
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on January 07, 2014, 09:45:52 PM
Hi,

The "browse on server" function (images, files) doesn't work out of the box.
you already reported somthing like this here (http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg178671.html#msg178671). I tried to fix (http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg178700.html#msg178700). You confirmed  (http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg178704.html#msg178704) it works. Maybe this is a cache problem again?
Once again I offer you to have a look at it if you grant me ftp and admin rights for a (test) installation as I can't confirm this problem.
Maybe this has to do with an error in the media handling of latest WB 2.8.4 REV 2082.
maybe cwsoft is right if you are using wb 2.8.4

regards

Eidth: ok now I can confirm for IE 11
Title: Re: Can anyone upgrade CKeditor?
Post by: Argos on January 07, 2014, 11:42:10 PM
I forgot to tell: my report was based on a clean WB 2.8.4 with the clean CKE from above. So everything default and new.
Title: Re: Can anyone upgrade CKeditor?
Post by: ruebenwurzel on January 08, 2014, 06:27:09 AM
Hello,

WB 2.8.4 trys to set the backend in IE9 compatible Modus. Look at Rev. 2006. There is a:

Code: [Select]
<meta http-equiv="X-UA-Compatible" content="IE=EmulateIE9" />
in:
admin/skel/themes/htt/loginBox.htt
admin/skel/themes/htt/loginForgot.htt
admin/skel/themes/htt/maintenance.htt
templates/wb_theme/templates/header.htt

This is not needed for CKEditor, so i removed it and got CKEditor running without error messages.

Matthias
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on January 10, 2014, 10:34:49 PM
Hi,

The "browse on server" function (images, files) doesn't work out of the box.
I forgot to tell: my report was based on a clean WB 2.8.4 with the clean CKE from above. So everything default and new.
can confirm the problem for IE11 (browser detection) but can't confirm any relation to wb284.
Should be fixed now:
Quote from: info.php
*  version 4.3.1.2 140110
 *  ! filemanager works with IE11 now, reported by argos: http://www.WebsiteBaker.org/forum/index.php/topic,17913.msg182267.html#msg182267

regards

Edith 1: thanks to all the other positive reports too. I really appreciate them :).

Edith 2: find updated version below
Title: Re: Can anyone upgrade CKeditor?
Post by: Argos on January 11, 2014, 10:27:48 AM
Confirmed! It works fine now in IE11. Thanks.
Title: Re: Can anyone upgrade CKeditor?
Post by: nibz on January 17, 2014, 12:52:18 PM

Quote from: info.php
*  version 4.3.1.2 140110
 *  ! filemanager works with IE11 now, reported by argos: http://www.WebsiteBaker.org/forum/index.php/topic,17913.msg182267.html#msg182267
[/quote]

Updated the addons repo to this last version :)
Title: Re: Can anyone upgrade CKeditor?
Post by: Luisehahne on January 17, 2014, 02:00:21 PM
Due to the security issues the add-on Repostory is locked

Dietmar
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on January 17, 2014, 06:59:25 PM
Hi,

Due to the security issues the add-on Repostory is locked
as these issue is posted in the cke thread I just want to note that it is not related to cke as far as I know by now.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: tiggerific on January 18, 2014, 07:34:01 AM
After upgrading CKEditor, I'm no longer able to "Upload" files or Create New Folder from ckeditor admin area. Any ideas?

Edit: Don't worry - I found that information back on page 2 of this thread :)

Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on January 22, 2014, 06:39:03 PM
found a little problem in wblink-dialog, if your choice is a topic-section (ckeditor/ckeditor/plugins/wblink/pages.php // line 94)

Code: [Select]
<?php
$topics 
$database->query("SELECT title, link FROM ".TABLE_PREFIX."mod_topics WHERE active=1 AND section_id = ".$section['section_id']);

its possible, that a topic has other values for the field "active" - from 0 to 6
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on January 22, 2014, 08:06:36 PM
Hi,

forgot to update (http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg175989.html#msg175989) pages.php will be done in next version.

regards

here we are:
Quote from: info.php
*  version 4.3.2 140131
 *  + using cke 4.3.2 full
 *  ! bug in wbsave plugin
 *  ! bug in wblink plugin reported by instantflorian and jacobi22 http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg184283.html#msg184283

Edith: find latest version down below
Title: link bug not solved?
Post by: Hartmut on February 13, 2014, 03:00:15 PM
Hello I use WebsiteBaker v2.8.3 r1638 at 2 different servers and have at one server problems with your CKeditor (v4.3.2.1 and v4.3.2). The problem is already know, white screen when I try to open the link menu. I thought this bug was already fixed? Could eventually another php-version be the problem, because your CKeditor v4.3.2.1 works at the another server like a charm?! It would be nice to have code highlighting and the same editor at both servers.
Title: Re: link bug not solved?
Post by: marmot on February 13, 2014, 11:15:49 PM
Hi,

thanks for reporting.
I thought this bug was already fixed?
I fixed a bug like this but that doesn't mean there are no more bugs in it ;).
Quote
Could eventually another php-version be the problem, because your CKeditor v4.3.2.1 works at the another server like a charm?!
a lot of reasons are possible and because of that I can only offer you to have a look at the problem when getting admin and ftp access to the problem site as long as I can't retrace the problem myself.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: tiggerific on March 02, 2014, 01:16:44 AM
I'm having this same problem with 4.3.1 as well - where the WBLINK icon works fine on one install and not on the other. The exact error on the non-working one is

Error: ReferenceError: InternPagesSelectBo x is not defined
Source File: http://growpartnerships.com/2014/modules/ckeditor/ckeditor/plugins/wblink/dialogs/wblink.js?t=DBAA
Line: 374

The only difference I have found between these two installs is that the working one is listed as:

CMS Version 2.8.3
Revision 1638
Admin version 1.6

The one that doesn't work is listed as:

CMS Version 2.8.3 SP1
Revision 1638
Admin version 1.6

Was there a change when SP1 was added? The revision is the same. Any help tracking down this error would be really good. Thanks :)

Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on March 02, 2014, 01:55:32 AM
Quote
The only difference I have found between these two installs is that the working one is listed as:

CMS Version 2.8.3
Revision 1638
Admin version 1.6

The one that doesn't work is listed as:

CMS Version 2.8.3 SP1
Revision 1638
Admin version 1.6

Was there a change when SP1 was added? The revision is the same. Any help tracking down this error would be really good. Thanks Smiley


the only different is the header-Template (header.htt) from the admin-theme. in older WB-Version was there no Output for a ServicePack-Number.
Code from the old header.htt
Code: [Select]
       <td class="version">
        Version {VERSION}<br />
    Revision {REVISION}
        </td>
</tr>

Code from the 2.8.3 header.htt
Code: [Select]
<td class="version">
        Version {VERSION} {SP}<br />
    Revision {REVISION}
        </td>
</tr>
The upgrade-instruction (http://www.WebsiteBaker.org/forum/index.php/topic,23658.msg160358.html#msg160358) says: delete the folder template/wb_theme
but only, if you make an update from wb 2.8.x to wb.2.8.3, but not in update from wb 2.7.x to 2.8.3

thats all

i'm sure, you work with the 2.7.x-header.htt on the wb with no SP1

and your InternPagesSelectBo x-Error

this variable is defined in modules/ckeditor/plugins/wblink/pages.php
for a test... rename this file and copy the same file from the working installation
Title: Re: Can anyone upgrade CKeditor?
Post by: tiggerific on March 02, 2014, 03:27:02 AM

and your InternPagesSelectBo x-Error

this variable is defined in modules/ckeditor/plugins/wblink/pages.php
for a test... rename this file and copy the same file from the working installation

When I said they are using the exact same version of CKE - I mean I zipped up the one on the working one, and installed it on the non-working one. They are exactly the same files.

I got tired of trying to find any differences between them, so I uninstalled the one on "SP1" and installed a copy from the working version.


Title: Re: Can anyone upgrade CKeditor?
Post by: tiggerific on March 02, 2014, 03:33:45 AM
Quote
the only different is the header-Template (header.htt) from the admin-theme. in older WB-Version was there no Output for a ServicePack-Number.

And I only ever use the Argos theme - the header.htt on both sites has the following:

Code: [Select]
<span class="version">CMS Version {VERSION} {SP}</span><br/>
So I'm guessing, it's more like the SP number just didn't exist in the earlier one.

Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on March 02, 2014, 01:27:31 PM
Hi,

thanks for reporting.
I'm having this same problem with 4.3.1 as well - where the WBLINK icon works fine on one install and not on the other.
please always test the latest version (4.3.2 (http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg184292.html#msg184292)), although I don't this will help here
Quote
The exact error on the non-working one is
Error: ReferenceError: InternPagesSelectBo x is not defined
Source File: http://growpartnerships.com/2014/modules/ckeditor/ckeditor/plugins/wblink/dialogs/wblink.js?t=DBAA
Line: 374
that's fine but doesn't help to much as I have to take a look at the creation of the variable during runtime
Quote
Was there a change when SP1 was added? The revision is the same. Any help tracking down this error would be really good. Thanks :)
I don't think that this problem depends on SP1.
If you really want help please grant admin and ftp rights to the site with the error.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on March 02, 2014, 02:02:03 PM
Quote
the only different is the header-Template (header.htt) from the admin-theme. in older WB-Version was there no Output for a ServicePack-Number.
And I only ever use the Argos theme - the header.htt on both sites has the following:
Code: [Select]
<span class="version">CMS Version {VERSION} {SP}</span><br/>So I'm guessing, it's more like the SP number just didn't exist in the earlier one.


only in the wb. 2.8.4 the file framework / class.admin.php read the settings and set the placeholder.
in wb 2.8.3 in the line 134, in wb 2.8.4 in line 180
Code: [Select]
'SP' => (defined('SP') ? SP : ''),the database entry for that is in the table "settings" on page 2 in the field wb_sp

in wb 2.8.3 the class.admin.php read the file admin/interface/version.php, so take a look into this file and search for a code like this
Code: [Select]
if(!defined('SP')) define('SP', 'SP1');
if you start the upgrade-script after your upgrade, this script read the file admin/interface/version.php and write the version and the SP into the database, but wb doesnt use this value directly from the database
Title: Re: Can anyone upgrade CKeditor?
Post by: tiggerific on March 03, 2014, 01:24:10 AM
I don't think that this problem depends on SP1.
If you really want help please grant admin and ftp rights to the site with the error.
regards

I'm happy to do that, as I would like to resolve this issue. Nobody has yet asked me to provide that information and I'm not sure who I should send it to. I'm obviously not going to post the info in the forum.
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on March 03, 2014, 06:37:03 PM
Hi,

.. and I'm not sure who I should send it to. I'm obviously not going to post the info in the forum.
simply send me a pm.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: tiggerific on March 05, 2014, 12:23:51 AM
For anyone else who has had the problem of the Link button not loading the dialog, in my case at least, it turned out that several page titles (in fact news post titles) contained special characters. By special characters I mean those such as dashes and spaces which have been saved to the database as some ASCII/HTML/foreign equivalent.

In other words, the presence of these characters are not visible in the WB pages or news lists, but can be clearly seen in the page titles present in the database.

If you are still having this issue with the latest version, perhaps check your DB for page titles containing special characters and change them back to their text equivalent. This resolved the problem for me.

Thanks to marmot for his suggestion in tracking this down.

Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on March 05, 2014, 08:53:01 PM
Hi,

the experiences with the problems of tiggerific inspired me to try something new for the wblink plugin. Here we are:
Quote
*  version 4.3.3 140303
 *  + using cke 4.3.3 full
 *  ! update wblink plugin
 *  ! because of consecutive problems wblink plugin allows now only a definded set of characters for page item selection

reagrds

Edith: find latest version below
Title: Re: Can anyone upgrade CKeditor?
Post by: Ruud on March 10, 2014, 11:34:09 PM
Updated the addon repository.

http://addon.WebsiteBaker.org/pages/en/browse-add-ons.php?id=08A769F
Title: Re: Can anyone upgrade CKeditor?
Post by: gucci on March 24, 2014, 12:47:57 PM
Hallo marmot,

as described in the  "readme-faq.txt" I tried to integrate the editor.css.

editor.css
   1) _yourwbinstallation _/templates/_yourdefaulttemplate_/editor.css
   2) _yourwbinstallation _/templates/_yourdefaulttemplate_/css/editor.css
   3) _yourwbinstallation _/templates/_yourdefaulttemplate_/editor/editor.css
   4) _yourwbinstallation _/templates/wb_config/editor.css
   5) _yourwbinstallation _/modules/ckeditor/wb_config/editor.css


I have copied the editor.css in all folders but no style is visible in the editors drop-down-menu.
How does this work?

regards

gucci


Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on March 24, 2014, 01:08:41 PM
the editor.css set only css-styles for fonts and element in the selected code. its like the css-file for your frontend in the template folder, but works only in the editor area

what you need for your "private styles", is a editor.styles.js somewhere in your wb - recommened in the template folder - look into the ckeditor / wb_config-Folder for a example file
Title: Re: Can anyone upgrade CKeditor?
Post by: gucci on March 24, 2014, 05:04:09 PM
O.k.

Solution:
Copy the names of your styles into editor.styles.js below /* Block Styles */

Example:
   { name : 'Textstyle1'         , element : 'span', attributes :  { 'class' : 'Textstyle1' } },
   { name : 'Textstyle2'         , element : 'span', attributes :  { 'class' : 'Textstyle2' } },
         ....

Thanks to jacobi22
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on March 24, 2014, 05:33:30 PM
tip - the same proccedur, if you want some "individual" editor templates - take a look to ckeditor / wb_config-Folder and there to the file editor.templates.js
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on April 09, 2014, 09:34:03 PM
Hi,

Quote
*  version 4.3.4 140404
 *  + using cke 4.3.4 full
 *  ! update codemirror plugin to v. 1.10
 *  ! update youtbue plugin to v. 1.09

regards

Edith: find latest version below
Title: Re: Can anyone upgrade CKeditor?
Post by: Stefek on April 09, 2014, 09:57:28 PM
Vielen Dank für die Mühen.

Lokale Installation unter 2.8.4. funktioniert sehr gut.

Editor sieht sehr schick aus.
Auch Codemirror ist eine große Bereicherung m.E.

Das WB-Link Plugin scheint nicht richtig zu funktionieren.

Gruß,
Stefek
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on April 09, 2014, 11:01:10 PM
Hi,

Das WB-Link Plugin scheint nicht richtig zu funktionieren.
thanks for testing and reporting.
What is the problem with wb-Link? Which browser, which version, any errors, any errors in javascript console, maybe even a link to a site with problems would help really much to impove this module.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: Stefek on April 09, 2014, 11:58:11 PM
No errors at all are displaying.
Only the plugin isn't working as expected. It's behaving like the link plugin (where you set a regular link with a complete URL). The WB Link plugin usuallly displays a list of links to internal WB pages (from your installation).

Kind regards,
Stefek
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on April 10, 2014, 12:36:54 PM
Hi,

can't confirm (WB 2.8.3). Stefek, maybe you did not select the link type "WB Link"?
Title: Re: Can anyone upgrade CKeditor?
Post by: Stefek on April 10, 2014, 12:50:22 PM
Yeah right, it's an unexpected behaviour nonetheless, as I expect the pages list when clicking on the WB-Link icon.
But one can get used to it, so don't mind.
Thanks for the hint.

Regards,
Stefek
Title: Re: Can anyone upgrade CKeditor?
Post by: Stefek on April 25, 2014, 10:12:10 PM
Hello Marmot.

Is there any chance this module will be made compatible with the 2.8.4. methods for WBLink creation?
I like the module but using it in a 2.8.4. environment creates hardcoded entries in the database, whereas the FCK-Editor (which will be shipped with 2.8.4. unfortunatley) creates clean WBLink placeholders for both, the pages and the subpages of News/Bakery/Topics as well.

It would be great if the CKEditor would make use of the same methods.

Kind regards,
Stefek
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on April 26, 2014, 04:17:29 AM
Hi,

Is there any chance this module will be made compatible with the 2.8.4. methods for WBLink creation?
it's rather easy to patch the pages.php of the wblink plugin but as far as I know the wb team is already (about 6 months) working on a much better (what else) version of this module for wb 2.8.4.

regards

Edith1: Following the idea of stefek I attached a patched pages.php (\modules\ckeditor\ckeditor\plugins\wblink\pages.php). Patch is only short tested and active for news links (I don't have wb284 link adapted versions of topics and bakery by now) but it should be prepared for topics and bakery too (just read the comments.

Edith2: Deleted file as it is part of cke version >= 4.3.4
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on April 26, 2014, 06:09:56 AM
Is there any chance this module will be made compatible with the 2.8.4. methods for WBLink creation?
it's rather easy to patch the pages.php of the wblink plugin but as far as I know the wb team is already (about 6 months) working on a much better (what else) version of this module for wb 2.8.4.
its not correct
Luisehahne builds a working solution for that in the last year, but he was not finish with this module and now it looks, that he is never coming back

aber Hauptsache, einmal lustig drüber gemacht  :evil:
Title: Re: Can anyone upgrade CKeditor?
Post by: Stefek on April 27, 2014, 09:52:12 PM
Is there any chance this module will be made compatible with the 2.8.4. methods for WBLink creation?
it's rather easy to patch the pages.php of the wblink plugin but as far as I know the wb team is already (about 6 months) working on a much better (what else) version of this module for wb 2.8.4.
its not correct
Luisehahne builds a working solution for that in the last year, but he was not finish with this module and now it looks, that he is never coming back

aber Hauptsache, einmal lustig drüber gemacht  :evil:

Uwe,
I don't really understand what you are talking about.

Stefek
Title: Re: Can anyone upgrade CKeditor?
Post by: Stefek on April 29, 2014, 06:19:56 PM
OK,

thank you guys to all who contacted me via PM.
I appreciate that.

What I'd like to ask next is: is there someone willing to expand on the code so the same CKEditor can be used in the 2.8.3. and in the 2.8.4.?

Some new features will be released with the 2.8.4. which are new.

We could access them from within the CKE using the standard PHP if statement

if(class_exists...

and build a switch, using Marmots hardcoded variant for WB prior to 2.8.4. and the new methods for 2.8.4. and up.

As I said before, I really like this module and I would like to use it with 2.8.4.

Kind regards,
Stefek

Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on May 03, 2014, 12:28:59 PM
Hi,

here we are one more time:
Quote
 *  version 4.4.0 140501
 *  + using cke 4.4.0 full
 *  ! wblink plugin uses the extended wblink function of wb284 now: http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg187246.html#msg187246

regards

Edith: find latest version below
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on May 03, 2014, 12:51:22 PM
Works also in 2.8.3, thank you again for updating the module
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on May 03, 2014, 01:05:11 PM
I just found a small bug:

1) Click in WYSIWYG section on Template button
2) Select "Image and text" Template
3) Click on Save (either icon or save button beyond)

=> Result: "Sicherheitsverletzu ng!! Zugriff wurde verweigert!"

This does not happen if another template is chosen, probably the image placeholder causes the error.

WB 2.8.3, Single Tab security, PHP 5.3, Firefox 29 on Win 8.1
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on May 03, 2014, 03:34:24 PM
Hi,

thanks for testing and reporting.
I just found a small bug:
1) Click in WYSIWYG section on Template button
2) Select "Image and text" Template
3) Click on Save (either icon or save button beyond)
=> Result: "Sicherheitsverletzu ng!! Zugriff wurde verweigert!"
I really can't retrac this. I know this happens sometimes when using wbsave feature with singletab setting. But this problem occurs since introduction of wbsave feature (long ago). This might be because wbsave uses an iframe. I don't see any relation to the template function or even to the cosen template.
So I would suggest to do some more testings without using wbsave and then with multitab on.
I even recommend using multitab (wb does not) as long as somebody can show me a detailed attac which is only prevented when singletab on.

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on May 03, 2014, 03:44:06 PM
[at] Florian: do you use the standard ckeditor templates in the ckeditor-folder or a "private" editor.templates.js in your template folder?

if i see the editor field in the background behind the secure message in the last posted pic, it looks like other code- not the code from the editor.templates.js in ckeditor 4.4.0
I'm sure, the secure message has nothing to do with the ckeditor
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on May 04, 2014, 08:05:27 AM
Hi,

it's the default editor-templates.js (the other content in the screenshot was added before) and happens either clicking on wbsafe or clicking on the save-button beyond the editor field, but as I wrote before only with the described template "image and text".

It does of course not happen if Multitab is activated (and it's not really important for me neither, as I usually don't work with these templates - was just ment as a notice).

BR
-florian.
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on May 04, 2014, 10:14:41 AM
Hi,

.. and happens either clicking on wbsafe or clicking on the save-button beyond the editor field, but as I wrote before only with the described template "image and text".
I see. If it's not the wbsave bug I assumed then I'm interested in solving. Maybe sometime we find more information on when the issue appears or it even disapears in one of the next versions of cke.  :-D
Btw: There is no template "image and text", neiter in standard cke nor in your screeshot. So I assume you are talking about "image and title".

Thanks for your support!
regards
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on May 27, 2014, 08:27:00 PM
Hi,

one more time ...
Code: [Select]
*  version 4.4.1 140527
*  + using cke 4.4.1 full
*  ! changed wysiwyg-admin recognition

regards

Edith: find update below
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on May 28, 2014, 09:35:24 AM
Tested with WB 2.8.3 in Firefox & IE 11, works fine.
Thank you very much.
Title: Re: Can anyone upgrade CKeditor?
Post by: hgs on May 28, 2014, 11:08:20 AM
Tested with WB 2.8.3 in Firefox & IE 11, works fine.
Thank you very much.

Tested with WB 2.8.4 Rev. 2101
Error message looks like this

Code: [Select]
Exception: "Error in SQL-Statement" >> Exception detected in: [/framework/WbDatabase.php]
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on May 28, 2014, 09:28:04 PM
Hi,

thanks for testing and reporting
Tested with WB 2.8.4 Rev. 2101 Error message looks like this
Code: [Select]
Exception: "Error in SQL-Statement" >> Exception detected in: [/framework/WbDatabase.php]
should be fixed in attached version 4.4.1.1

regards

Edith: find latest version below
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on May 29, 2014, 09:43:30 AM
Yes, tested both in 2.8.3 and 2.8.4 (2101), no errors.
Title: Re: Can anyone upgrade CKeditor?
Post by: hgs on June 02, 2014, 02:47:44 PM
Hi,

thanks for testing and reporting
Tested with WB 2.8.4 Rev. 2101 Error message looks like this
Code: [Select]
Exception: "Error in SQL-Statement" >> Exception detected in: [/framework/WbDatabase.php]
should be fixed in attached version 4.4.1.1

regards
Also tested with WB2.8.4 Rev. 2101
Everything is good

Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on July 28, 2014, 05:58:22 PM
Hi,

Ooops!...I did it again:
Quote from: info.php
*  version 4.4.3 140727
 *  + function "show_wysiwyg_editor" accepts parameter "$toolbar" now to allow modules to use inidividual toolbars, thanks to dbs for suggesting
 *  ! using cke 4.4.3 full
 *  ! update skin moonocolor to v 1.3
 *  ! update wblink plugin to v 4.4.3

regards

[gelöscht durch Administrator]
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on July 28, 2014, 07:35:20 PM
Nice one.

$toolbar can be used like this:
Code: [Select]
show_wysiwyg_editor('content'.$section_id,'content'.$section_id,$content,'100%','350', $toolbar = "Mini");
Before, the example-toolbar "Mini" must be created in wb_ckconfig.js
Title: Re: Can anyone upgrade CKeditor?
Post by: Hans on July 28, 2014, 10:15:44 PM
Thanks Marmot and DBS!!
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on August 02, 2014, 11:52:20 PM
(for me) the combopanel (normal, h1 - h6) needs more width .
Easy solution is a new line in the backend-template.

For argos_theme is this the theme.css.
Code: [Select]
.cke_combopanel{width: auto!important;}
Or Changing CK-skin-css-files, but they are too much.

Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on August 15, 2014, 10:17:09 PM
Hi, the button "RemoveFormat" does nothing.
Can 'we' do something there?

WB2.8.3SP1, FF31.0
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on August 16, 2014, 08:13:44 AM
Hi,

Can't confirm (WB 2.8.3 SP2 FF 31, Win8) - when there are styles like bold, em or any M$Word-Crap in a selected text area, and then clicked on RemoveFormat, the styles are removed. Paragraph formatting like p, h3, div etc. are not removed, but I think this is not a bug but a feature.
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on August 16, 2014, 08:43:36 AM
Hm, i see a error if i click on removeformat:
Code: [Select]
TypeError: a.config.removeFormatAttributes.split is not a functionWill test again.
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on August 18, 2014, 08:08:36 PM
Have tested again, simply bold text. Every click on "RemoveFormat" produces the error.
CKEditor4.4.1.1

Is the syntaxhighlighter-plugin somewhere integrated?
Could need a tutorial for.

Solution found on http://ckeditor.com/addon/syntaxhighlight works
Title: Re: Can anyone upgrade CKeditor?
Post by: marmot on August 18, 2014, 10:13:47 PM
Hi,

Have tested again, simply bold text. Every click on "RemoveFormat" produces the error.
CKEditor4.4.1.1
is there a reason why you are not using version 4.4.3 (http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg189226.html#msg189226)?

regards
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on August 18, 2014, 11:24:34 PM
In the meantime, after posting, i tried 4.4.3 with the same result.

Reason:
I added a little bit code in the wb_ckconfig.js line27
Code: [Select]
CKEDITOR.editorConfig = function( config )

   
config.pasteFromWordPromptCleanup = true;
config.pasteFromWordRemoveFontStyles = true;
config.forcePasteAsPlainText = false;
config.ignoreEmptyParagraph = true;
config.removeFormatAttributes = true;

The last line makes a conflict with the RemoveFormat-Button, i think.
After commenting the line the button works.

And now i also see the syntaxhighlighter is integrated. *tach herr preil*
Saw some 'Code'-Buttons in the Toolbars (wb-ckconfig.js), also  'Syntaxhighlighter' and this is the right one.
In my link above is a new version 1.7 of syntaxhighlighter.

Thanks for hear my selfmade problems...
4.4.3 original works like it should.
Title: Re: Can anyone upgrade CKeditor?
Post by: niekfox on August 20, 2014, 10:28:49 PM
I’ve tried some solutions as here to find , but CKEditor (from Ad-ons)  4.3.3 date 10 march 2014 is nog working with new install of WB 2.8.3 SP 2

Its working with the old SP1 version!  But not with the 2.8.3 (or update to)

Language Dutch / English

The Editor ‘hangs’?  and it’s not loaded (don’t show up)
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on August 21, 2014, 04:08:48 PM
4.3.3

http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg190186.html#msg190186
Title: Re: Can anyone upgrade CKeditor?
Post by: niekfox on August 21, 2014, 09:01:08 PM
4.3.3

http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg190186.html#msg190186

? I dont know what you ment by this? I've tried that, but CKE is not working at all here.
Is it posible to replace the 4.3.3. to a better one that works with the new WB version 2.8.3. SP2 Revision 1639 ?

Thank you !
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on August 21, 2014, 09:36:34 PM
read marmot's question in the linked posting - why not cke Vers. 4.4.3? 
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on August 22, 2014, 10:56:00 PM
Hi, in the sourcecode-view i see a new line after every ", " (comma whitespace).

e.g. rgb(0, 0, 0) will displayed as

rgb(0,
0,
0)

How can i change this?
Title: Re: Can anyone upgrade CKeditor?
Post by: Kant on August 23, 2014, 06:42:52 PM
Hi, in the sourcecode-view i see a new line after every ", " (comma whitespace).

e.g. rgb(0, 0, 0) will displayed as

rgb(0,
0,
0)

How can i change this?

The ckeditorplus class got a bug within the "pretty" property ... you''ll have to set it to "false", e.g.
File: ckeditor/ckeditor/CKEditorPlus.php
Line: ~24
Code: [Select]
<?php // ignore this line, please
public $pretty false;
or you have to set it via the instance inside the include.php e.g.
line ~215
Code: [Select]
<?php // ignore this line, please

if ($toolbar$ckeditor->config['toolbar'] = $toolbar;
$ckeditor->pretty false;
direct after the setting the toolbar, but(!) before the "toHTML" call to stopp this misbehavior.

Kind regards
Kant
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on August 23, 2014, 07:13:32 PM
YES, it works!
Especially in <pre>-tags was the linebreaks also in frontend visible.

Thank you
Title: Re: Can anyone upgrade CKeditor?
Post by: Stefek on August 27, 2014, 02:38:09 PM
Hello Marmot,

is there any chance this Addon can be upped to the official Addon Repository?
Right now there is one CKE here
http://addon.WebsiteBaker.org/pages/en/browse-add-ons.php?id=08A769F

However, it is an older version and in the Description Details
Forum Discussion (EN)    Click here to visit
points to this thread started by another user (who is no more registered in the forum - or at least not with this account ;-)):
http://www.WebsiteBaker.org/forum/index.php/topic,17913.0.html

As people pick up the older version from the repo and complain in the forum about its issues, it would be very good if your latest version could be upped and the descriptions changed accordingly.

If you need any help with this, let me know. But please let's do it.

Kind regards,
Stefek
Title: Re: Can anyone upgrade CKeditor?
Post by: Hans on August 27, 2014, 02:39:23 PM
Thanks a 1000 times Marmot
Hans
Title: Re: Can anyone upgrade CKeditor?
Post by: Hans on August 27, 2014, 09:29:43 PM
Thanks a 1000 times Marmot
Hans

@Marmot
Seems that I cannot edit my last post. So here for now:
Like Stephek I would like to see I that your contribution to the WebsiteBaker ckEditor became part of the repository.
Hans
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on August 27, 2014, 11:19:39 PM
I vote also for 4.4.3 into repository  :wink:
Title: Re: Can anyone upgrade CKeditor?
Post by: niekfox on September 01, 2014, 08:39:54 AM
If it finaly works now for some off you... wil it come in the Add-ons Repository ?

Thank you in advance !
Title: Re: Can anyone upgrade CKeditor?
Post by: Stefek on September 01, 2014, 03:13:34 PM
The CKEditor was updaten on the AddonRepository today:
http://addon.WebsiteBaker.org/pages/en/browse-add-ons.php?id=08A769F

Thank you Ruud.

Kind regards,
Stefek
Title: Re: Can anyone upgrade CKeditor?
Post by: Hans on September 01, 2014, 04:47:58 PM
Thanks man, great!
Title: Re: Can anyone upgrade CKeditor?
Post by: niekfox on September 06, 2014, 12:16:37 PM
Thanks !  great work !  :-D
Title: Re: Can anyone upgrade CKeditor?
Post by: niekfox on September 16, 2014, 02:30:25 PM
.. Only in Google Chrome, it does not work.  (Editor is nog comming on the screen)
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on September 18, 2014, 10:04:06 AM
Can't confirm. Which Chrome version, which OS, which WB version?
Title: Re: Can anyone upgrade CKeditor?
Post by: ruebenwurzel on September 22, 2014, 06:39:34 AM
Hello,

it seems that the latest ckeditor modul uses editor.css only from the standard template. If you use another template for special sites the editor.css of this template isn't loaded.

I think it would be better not to look if the standardtemplate (set in options) has a editor.css, it should be looked if the template from the page wich is edited has a editor.css.

Regards
Matthias
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on September 22, 2014, 01:29:08 PM
Quote
it seems that the latest ckeditor modul uses editor.css only from the standard template.

works for me without problems with every template
Title: Re: Can anyone upgrade CKeditor?
Post by: niekfox on September 26, 2014, 03:47:11 PM

 Sorry, its in the template of the page, i must Reload the page, and then it comes !
 (not at the first load)

 But now that i know that, i can live with it.

 Thank you !
 
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on September 28, 2014, 09:15:46 AM
Hi, the image-dialog -> tab "Link" could provide something more as only URL and target.
Would be nice if there is a field "Relation" (for Popups). Maybe a field "Class" is also a good idea.

In FCK this was a good feature, but the FCK is old crap. :)

Is it possible? Or is it to much work and the user should use the normal Link-menu-button?
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on September 28, 2014, 11:30:19 AM
Other question.
I have made a template for inserting image with caption, incl. link around.
Image and link have pathes to existing dummy-files in href and src.

Right-click on the image shows the image-dialog with filled pathes to the dummy-files. This is ok and right.

But double-click on the image shows the image-dialog without filled pathes.
if the user now choose a image in the image-tab, in the same moment the link-tag will be removed. In sourcecode only the image-tag is there.
Can somebody confirm this?

CK 4.3.3, WB 283 SP1, PHP 5.4, FF 32.0.3
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on January 10, 2015, 06:06:45 PM
Excellent work on this module.  Thank you!

I am trying to accomplish two things.
1. change the DEFAULT (starting) width of the CKEditor editor window.
2. allow resizing of the CKEditor editor window.

CMS Version 2.8.3 SP3 Revision 1640
Admin version 1.6
CKEditor 4.4.3
Argos Theme 1.7.0

I have the CKEditor editor files copied to my "_yourwbinstallation _/templates/_yourdefaulttemplate_/editor/"
editor.css
editor.styles.js
editor.templates.js
readme-faq.txt
wb_ckconfig.js

In "wb_ckconfig.js", I have made the suggested (CKEditor Docs) changes to:
Code: [Select]
    // The standard height and width of CKEditor in pixels.
    config.height           = '250';
//    config.width            = '900';
    config.width            = '1200';
    config.toolbarLocation  = 'top';

    // Define possibilities of automatic resizing in pixels. Set config.resize_enabled to false to
    // deactivate resizing.
    config.resize_enabled   = true;
    config.resize_minWidth  = 500;
    config.resize_maxWidth  = 1500;
    config.resize_minHeight = 200;
    config.resize_maxHeight = 1200;
//    config.resize_dir = 'vertical';
    config.resize_dir = 'both';

None of the width settings take effect.  The only way I can find to change the (starting) width from 900 to 1200px is to change the table width in the header.htt file in the Argos Theme 1.7.0.

config.resize_dir = 'both'; does not seem to stick.  If I open WYSIWYG admin page, and look at the source code, it always shows:
Code: [Select]
<script type="text/javascript">//<![CDATA[
CKEDITOR.replace('content26',
 {"ModulVersion":"4.4.3","format_tags":"p;div;h1;h2;h3;h4;h5;h6;pre;address","skin":"moono","language":"en","defaultLanguage":"en","resize_dir":"vertical","autoParagraph":true,"contentsCss": ..... "browserContextMenuOnCtrl":true,"scayt_sLang":"en_US","scayt_autoStartup":false,"height":"350","width":"100%"});
//]]></script>
...and ""resize_dir":"vertical"" is always set to "vertical".  Has this been hard coded into the CKEditor 4.4.3?  Or am I missing how to accomplish this properly?

I can make other changes in the wb_ckconfig.js, and they take effect without issue. (e.g. toolbars)

Any help would be greatly appreciated.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on January 10, 2015, 06:36:55 PM
Quote
None of the width settings take effect.  The only way I can find to change the (starting) width from 900 to 1200px is to change the table width in the header.htt file in the Argos Theme 1.7.0.
the values in the config-file (ckeditor/include.php) are standard values, the most modules gives own values for width & height, like wysiwyg-module in modules/wysiwyg/modify.php

Code: [Select]
show_wysiwyg_editor('content'.$section_id,'content'.$section_id,$content,'100%','350');
Quote
and ""resize_dir":"vertical"" is always set to "vertical".

is it "hardcodet" to "vertical" in the include.php from the ckeditor, possible values: both, vertical, horizontal,
feel free to change the value there
if you dont have a setting in this include-file, you can set the resize_dir in a wb_ckconfig.js in your frontend-template or in the ckeditor-module-folder like modules/ckeditor/wb_ckconfig/wb_ckconfig.js

Quote
I can make other changes in the wb_ckconfig.js, and they take effect without issue. (e.g. toolbars)
see example from dbs or take a look to page 6 here in this thread
for other custom config settings see the path's in ckeditor/include.php
http://www.WebsiteBaker.org/forum/index.php/topic,25334.msg189229.html#msg189229
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on January 12, 2015, 05:10:17 AM
I must be confused.  I thought the idea with moving the config files (e.g. wb_ckconfig.js) to my template folder was so I can make changes there INSTEAD of the source module files, since the module files will be overwritten if you update/upgrade.

I have made the change from "vertical" to "both" in the module "include.php" file and it works, thanks.  I guess I'll just have to remember to make the change each time I update CKEditor in the future.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on January 12, 2015, 01:09:00 PM
I must be confused.  I thought the idea with moving the config files (e.g. wb_ckconfig.js) to my template folder was so I can make changes there INSTEAD of the source module files, since the module files will be overwritten if you update/upgrade.

"problem" is the order in the ckeditor-include-file.
take a look into this file to understand - nearly in the top of this file you found some basic settings like (only 3 for example)
- $ckeditor->config['skin'] = 'moonocolor';
- $ckeditor->config['format_tags'] = 'p;div;h1;h2;h3;h4;h5;h6;pre;address';
- $ckeditor->config['resize_dir'] = 'vertical';

after this basic settings comes the path to the config files.
if WB calls the editor, it starts to load the settings in the top of the include, after that, it looks into the custom config files, but it is too late, to load the settings for this values again
there are only two ways to change the config from this point
way 1: load the custom config files before set standard values (like older ckeditor versions)
way 2: load custom values in the function call, but then you have to change the function (same problem with overwrite in upgrade)

i'll show way 1 for you  and i'll talk with marmot - maybe its possible to change the order in the include-file

solution is testet and works - after that, you can set your custom settings in your individual config-files like wb_ckconfig.js in template folder

look at the begin from the ckeditor / include.php for the standard settings like this

Code: [Select]
/**
         * A list of semi colon separated style names (by default tags) representing
         * the style definition for each entry to be displayed in the Format combo in
         * the toolbar. Each entry must have its relative definition configuration in a
         * setting named "format_(tagName)". For example, the "p" entry has its
         * definition taken from config.format_p.
         * @type String
         * @default 'p;h1;h2;h3;h4;h5;h6;pre;address;div'
         */
        $ckeditor->config['format_tags'] = 'p;div;h1;h2;h3;h4;h5;h6;pre;address';

        //$ckeditor->textareaAttributes = array( "rows" => 8, "cols" => 80 );

        /**
         *        If you also want to look for the template-specific css, you can simple add the files like below.
         *        Just uncomment one or both of the following two lines ;-) by removing the double-slashes ...
         *
         */
        //        $files['contentsCss'][]= '/template.css';
        //        $files['contentsCss'][]= '/css/template.css';

        /*
        * The skin to load. It may be the name of the skin folder inside the editor installation path,
        * or the name and the path separated by a comma.
        * Available skins: moono, moonocolor
        */
        $ckeditor->config['skin'] = 'moonocolor';
       // $ckeditor->config['contentsLangDirection'] = 'rtl';

        /**
         *        Setup the CKE language
         *
         */
        $ckeditor->config['language'] = strtolower(LANGUAGE);

  // The language to be used if config.language is empty and it's not possible to localize the editor to the user language.
        // $ckeditor->config['defaultLanguage']  = strtolower(DEFAULT_LANGUAGE);
  $ckeditor->config['defaultLanguage']  = 'en';

        $ckeditor->config['resize_dir'] = 'vertical';

cut off this lines and paste it nearly to the end, but before this lines

must stay at the last lines in the include.php
Code: [Select]
$ckeditor->reverse_htmlentities($content);

        echo $ckeditor->to_HTML( $name, $content, $ckeditor->config);
}
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on January 12, 2015, 04:29:14 PM
Thank you very much for the explanation.  It's all crystal clear to me now.

For my purposes, I will not bother to implement your Solution 1 (although I appreciate your efforts), as the ['resize_dir'] = 'vertical'; setting is the only one which I need changed, and it's easier to just change it in the included.php, rather than moving code around.  And as we know, either method will require a redo, after an upgrade.

I wonder why these settings are set in the include.php:
- $ckeditor->config['skin'] = 'moonocolor';
- $ckeditor->config['format_tags'] = 'p;div;h1;h2;h3;h4;h5;h6;pre;address';
- $ckeditor->config['resize_dir'] = 'vertical';

I realize you need to have some defaults set, but can't they just be set in the wb_ckconfig.js, which is called by the include.php?  This would mean everything that NEEDS to be set is, for those who don't want to get into the code to customize, but for those who do want more control, they just have to make changes in their template folder copy of wb_ckconfig.js.  And then those custom settings will not be lost with a module upgrade.

Again, I am not trained, so there is probably a good reason for this.  I am just curious.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on January 12, 2015, 05:03:30 PM
and it's easier to just change it in the included.php, rather than moving code around.  And as we know, either method will require a redo, after an upgrade.

another methode without moving code

set two slashes at the begin from this line in the ckeditor / include.php  like this to comment it out
Code: [Select]
//$ckeditor->config['resize_dir'] = 'vertical';
and define it in your custom config files in the template folder like
Code: [Select]
$ckeditor->config['resize_dir'] = 'both';
then you have a working solution - also when the include.php changed in the next upgrade
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on January 12, 2015, 05:37:06 PM
another methode without moving code

set two slashes at the begin from this line in the ckeditor / include.php  like this to comment it out
Code: [Select]
//$ckeditor->config['resize_dir'] = 'vertical';
and define it in your custom config files in the template folder like
Code: [Select]
$ckeditor->config['resize_dir'] = 'both';
then you have a working solution - also when the include.php changed in the next upgrade


That's what I have done.  But that is the point of my questions.  Why set these defaults at all in include.php?  Why not just let them be set by the wb_ckconfig.js file?

The resize is already set to vertical in wb_ckconfig.js:
Code: [Select]
$ckeditor->config['resize_dir'] = 'vertical';
So those who wish to, can just change that to 'both' in their template folder version of wb_ckconfig.js

Why the redundancy?  Especially when it cripples some custom setting ability of the template folder version of wb_ckconfig.js

I know I can just use these work-arounds... but I am thinking of EVERYONE moving forward, and making it more obvious how to make these changes for themselves.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on January 12, 2015, 06:40:50 PM
Why set these defaults at all in include.php? 

 i dont know  ;-)
maybe its a little mistake, maybe a adwise from the cke-group, i dont know  :roll:
this definitions was not there in the include.php in older module version like Vers 0.65, but in Vers 0.72

i write a PM to marmot and i hope, he can change this in the next version or explain it
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on April 09, 2015, 09:27:28 AM
it seems that the latest ckeditor modul uses editor.css only from the standard template. If you use another template for special sites the editor.css of this template isn't loaded.

I think it would be better not to look if the standardtemplate (set in options) has a editor.css, it should be looked if the template from the page wich is edited has a editor.css.

Can confirm this with cke 4.4.3
Now i could also need a solution for this.
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on April 10, 2015, 12:32:55 PM
A little angel named Dietmar has found a solution.
Works in my test with ckeditor 4.4.3

Replace in modules/ckeditor the attached include.php (rename to include.php)
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on April 10, 2015, 03:59:26 PM
Does this update fix the issue I brought up?
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on April 10, 2015, 06:49:36 PM
Hi, can't see a "both"-effect.
Not with change in ckeditor/wb_config/wb_ckconfig.js  and not with changes in my_template/wb_ckconfig.js
'both' or 'horizontal' are not usable.

The "vertical"-setting in include.php should be commented out. Don't know why this setting is not overwritable by wb-ckkonfig.js.
Title: Re: Can anyone upgrade CKeditor?
Post by: Luisehahne on April 10, 2015, 06:58:21 PM
Hi,

because the ckeditor php class create a json with the parameter settings from the include.php. This overwrites the settings in the wb_config.js and not wb_config.js overwrite the settings in include.php.

And if you comment out some settings in the include.php, this settings will be set by wb_config.js

Dietmar

Title: Re: Can anyone upgrade CKeditor?
Post by: Yetiie on April 16, 2015, 03:39:27 PM
Just as suggestion:

Font Awesome becomes more and more popular.
Not only for Bootstrap but other projects with other frameworks too.

One Problem to use this Icons is, that the editor cannot add them easily to the page.
And I recognize: in normal mode the CKEditor removes the standard symbol html code (empty <i>-Tags) from the code.


Today I found following module for CKEditor:
http://ckeditor.com/addon/fontawesome (http://ckeditor.com/addon/fontawesome)

The Idea: Symbols at the fingertips of the editors.
Not only for bootstrap projects !!!!
A little modul-addon could improve the usabilities of the whole wb a lot :-)


Has somenone experience with this module or uses it?
What do you think about to ad this to the wb version for the editor?
Title: Re: Can anyone upgrade CKeditor?
Post by: Luisehahne on September 08, 2015, 06:20:44 PM
New CKEditor Version 4.5.3, Pls download and test.

http://addon.WebsiteBaker-next.de/pages/en/browse-add-ons.php?id=08A769F

Dietmar

Title: Re: Can anyone upgrade CKeditor?
Post by: Hans on September 09, 2015, 11:08:52 AM
Hello Dietmar

as I wrote in private earlier, the editor works fine now for inserting images in responsive websites (with this code of course:
Code: [Select]
img {
  width: auto;
  max-width: 100%;
  height: auto;
}
)

I tested some more and until now I haven't found any issues.

This is a great leap now almost every website has to be responsive.

It would be nice if features like adding classes to an image and spaces around them could be re-implemented.
Title: Re: Can anyone upgrade CKeditor?
Post by: Luisehahne on September 09, 2015, 12:16:35 PM

the image2 plugin is a ready plugin by ckeditor. I'm not happy with it. You can remove it as follows:

Line 212
Code: [Select]
<?php
remove entry image2 from $ckeditor
->config['extraPlugins'] =
to $ckeditor->config['removePlugins'] = 

Dietmar
Title: Re: Can anyone upgrade CKeditor?
Post by: hgs on September 09, 2015, 01:43:56 PM
Hallo zusammen

Nach dem Update finde ich die "Abstände" zum Bild nicht mehr und es wird keine "Vorschau" gezeigt.
Siehe Bilder
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on September 09, 2015, 02:09:21 PM

the image2 plugin is a ready plugin by ckeditor. I'm not happy with it.

yes, the image2-Plugin is a step back, no extra css class, no title etc. It give's a lot of trouble, if the user is using something like that in his page.

please remove it from the standard package, the "old" image-plugin works also with html5

another point: the code-plugin - the plugin-Version from the last ckeditor-version 4.4.3. or 4.4.4 works without problems, the new plugin-version shows me only a empty field with my pre-css-class without output. i see my code only in the source code in the backend. maybe something goes wrong in the ckeditor.js
i'll check this now with a new download from the ckeditor-page
Title: Re: Can anyone upgrade CKeditor?
Post by: Hans on September 09, 2015, 03:21:16 PM
I agree with the critique and find it a pity that so much functionality has been offered only for making the code work in responsive websites.
I would like to use the WB standard too, but I see that when I have an image that is wider than its container the image is malformed with this code:
Code: [Select]
<p><img alt="" src="http://www.yyyy.nl/media/plaatjes/600-brandenburg-50492.jpg" style="width: 640px; height: 427px;" /></p>

which is the usual code (mind the "style" )  and will be proportional scaled with this code:
Code: [Select]
<p><img alt="" height="427" src="http://www.yyy.nl/media/plaatjes/600-brandenburg-50492.jpg" width="640" /></p>
which is the code that version 5.4.3 produces.
I would be glad if someone could point me in the right direction to make that happen. I couldń find a solution on StackOverflow.

@jacobi22 Maybe you pointed to a possible solution when you wrote that the old image plugin also works with html 5?
Or did I oversee something?

Auf (mein ;-) ) "Deutsch":

Ich stimme mit Ihrer Kritik, denn es ist in der Tat eine Menge verloren.
Ich möchte auch lieber das Standard WB CKEditor verwenden aber ich sehe, dass, wenn ich ein Bild, das breiter als sein Behälter ist platziere das Bild fehlerhaft (verzerrt) ist mit diesem Code (beachte den "inline style" Teil:
Code: [Select]
<p><img alt="" src="http://www.yyy.nl/media/plaatjes/600-brandenburg-50492.jpg" style="width: 640px; height: 427px;" /> </ p> Das ist die übliche Code.
Mit
Code: [Select]
<p><img alt = "" height = "427" src="http://www.yyyy.nl/media/plaatjes/600-brandenburg-50492.jpg" width="640" /> </ p> wird das Bild proportional skaliert: Dass ist die Code, der version 5.4.3 produziert hat.

Ich würde mich freuen, wenn jemand mich in die richtige Richtung weisen könnte Ich konnte eine Lösung auf Stackoverflow leider nicht finden

@jacobi22 Vielleicht haben Sie auf eine mögliche Lösung hingewiesen wenn Sie schrieb, dass das alte Image-Plugin auch mit HTML 5 funktioniert?? Muss dann etwas irgendwo in CKEditor geändert werden?
Ich weiss: Es ist kein WB Sache aber es wäre schön wenn Jemand eine Lösung hätte.
Title: Re: Can anyone upgrade CKeditor?
Post by: instantflorian on September 09, 2015, 05:29:32 PM
I found at stackoverflow a solution (http://stackoverflow.com/questions/2051896/ckeditor-prevent-adding-image-dimensions-as-a-css-style) which *seems* to work.

At the end of wb_ckconfig.js (either in /modules/ckedidor/wb_config/wb_ckconfig.js or in /templates/$yourtemplatename/wb_ckconfig.js add the following lines of code:

Code: [Select]
CKEDITOR.on('instanceReady', function (ev) {
// Ends self closing tags the HTML4 way, like <br>.
ev.editor.dataProcessor.htmlFilter.addRules(
    {
        elements:
        {
            $: function (element) {
                // Output dimensions of images as width and height
                if (element.name == 'img') {
                    var style = element.attributes.style;

                    if (style) {
                        // Get the width from the style.
                        var match = /(?:^|\s)width\s*:\s*(\d+)px/i.exec(style),
                            width = match && match[1];

                        // Get the height from the style.
                        match = /(?:^|\s)height\s*:\s*(\d+)px/i.exec(style);
                        var height = match && match[1];

                        if (width) {
                            element.attributes.style = element.attributes.style.replace(/(?:^|\s)width\s*:\s*(\d+)px;?/i, '');
                            element.attributes.width = width;
                        }

                        if (height) {
                            element.attributes.style = element.attributes.style.replace(/(?:^|\s)height\s*:\s*(\d+)px;?/i, '');
                            element.attributes.height = height;
                        }
                    }
                }



                if (!element.attributes.style)
                    delete element.attributes.style;

                return element;
            }
        }
    });
});

Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on September 09, 2015, 06:27:06 PM
Quote
@jacobi22 Maybe you pointed to a possible solution when you wrote that the old image plugin also works with html 5?
Or did I oversee something?

no, not you - it was my fault - sorry for that, i did'nt read the complete docu and understand your problem wrong.

the code from the image2-plugin is html5-conform, but the plugin give not so much possibilitys like the "old" standard image-plugin.
the "old" image-plugin give a non-html5-compatible code, if its use border or hspace

a little history.... the new image2-plugin is a "new" plugin from the ckeditor.com-webpage (means: is a first step, maybe it come a better version in the future), a try to give some html5-compatible code in the editor. It give's another plugin that give a little more service for responsive pictures
here the plugin -> http://ckeditor.com/addon/imageresponsive
and here a picture from the interface in the backend
(https://i.gyazo.com/eecd7a75a9d6db9b3c2fc9fcf56deeb9.png)

same problem.... no css-class, no style-informations  :roll:

from my point of view.... at the moment only two ways
1. using the image2-plugin without preview in the interface, without field for a class-name etc
2. using the "old" - standard-image-plugin combined with the solution from florian

i talk with Dietmar the last ours to found the best solution and we found, that the best way is it, to remove the image2-plugin from the package
for the fast solution, its possible to remove the image2-plugin, if you follow the instructions from post#197 (http://forum.WebsiteBaker.org/index.php/topic,25334.msg200332.html#msg200332)

after that, you have the "old" image-interface with the tabs and the solution from florian, works without problems for html5 and for me with the css in the bottom also in html4.x (no trouble with the validator because the missing px in with & height
 

on my own hp i use the fckeditor, this give me a html5-conform code like this
Code: [Select]
<img width="315" height="200" alt="" class="textbild aboutpic0" src="http://xyz.de/media/banner2.png" />but its also possible, to edit the code in the source-code-mode in the ckeditor and remove the px there or (better way) if you use the code from Florian


than i have two classes for every picure, called for me with "textbild" (a picture inside in the content) and the class "aboutpicX" (give some styling to every pic like a border, margin-left etc)

now my css
for all pics - is needed for responsive
Quote
img {
    height: auto;
    max-width: 100%;
}

the class textbild
Code: [Select]
.textbild {
    max-width: 50%;
    max-height:50%;
    padding: 0;
}

and the individual styling (its not needed for responsive)
Code: [Select]
.aboutpic0 {
border: 2px solid #003480;
float:right;
margin-left:15px;
margin-right:5px;
margin-bottom:5px;
margin-top:15px}

this works fine in my responsive html5-template

Thx also to Florian for the solution!
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on September 09, 2015, 07:15:28 PM
so, latest version without the image2-plugin and with the solution from florian is now in the addon-area

http://addon.WebsiteBaker-next.de/pages/en/browse-add-ons.php?id=08A769F
Title: Re: Can anyone upgrade CKeditor?
Post by: Hans on September 09, 2015, 07:20:49 PM
Wow, thanks both of you.
Just a little note.
I have little time this evening but I'll try in the course of tomorrow.
Thank you again!
Title: Re: Can anyone upgrade CKeditor?
Post by: Hans on September 09, 2015, 10:55:47 PM
Had to try hahaha.
It works perfect! It even works after altering the dimensions afterwards
Hope it will make it to the official 4.5.3 (with the release history accordingly) in the repo
Thanks, Dietmar, Florian and Uwe.
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on September 10, 2015, 04:42:16 AM
I installed this update.  I'm not a fan of moonocolor, so I switched back to moono and the oembed icon does not display in the toolbar.

I see that the default oembed icon is included in the moonocolor skins/icons.png
It is not in the moono skins/icons.png
I always had it as an insert plugin.

So, I tried playing around with my config.toolbar_WB_D efault in                /wb_config/wb_ckconfig.js
Nothing I change seems to take effect.  Maybe I'm just tired, but I was sure this is how I always added, moved toolbar icons in the past.

Can anyone help me here?
Thanks!
Title: Re: Can anyone upgrade CKeditor?
Post by: Luisehahne on September 10, 2015, 04:53:55 AM
Tkx for your report. I will have  a look and going to fix it.

Dietmar

Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on September 10, 2015, 05:08:06 AM
Just to clarify,
The default oembed icon is included in the moonocolor skins/icons.png
It is not in the moono skins/icons.png
It didn't used to be included in either.
I always had it added from it's plugin icon folder.
Hope this helps.

I then tried simply switching the 'image' and 'flash' order in the WB_Default, but that didn't happen either.

I checked the include.php file to see if something there is stopping the updated to wb_config/wb_ckconfig.js from showing.  I did empty my cash, close browser, but still nothing changed.
Title: Re: Can anyone upgrade CKeditor?
Post by: Luisehahne on September 10, 2015, 05:50:07 AM
Pls check again, new package is online. I updated the skin mono

Directdownload (http://addon.WebsiteBaker-next.de/pages/en/browse-add-ons.php?download=08A769F)

Dietmar
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on September 10, 2015, 06:12:29 AM
I tried installing, but WB said Already Installed.  So I just uploaded the two moono png's and now a bunch of my toolbar icons are wrong.

What's the best way to revert back to an older version of a module?  I just want to go back, to see if that fixes this issue.
Title: Re: Can anyone upgrade CKeditor?
Post by: hgs on September 10, 2015, 07:47:28 AM
 (Y) (Y)
Musste zwar den "alten Neue" deinstallieren, Fehlermeldung wie bei sky writer.
Aber jetzt ist alles wieder so komfortabel wie mit der Version 4.4.7

Danke an alle
 (Y) (Y)

Google Translate
Had to uninstall while the "old new" error message as in sky writer.
But now everything is as comfortable as with the version 4.4.7

Thanks to all
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on September 10, 2015, 03:43:47 PM
I tried installing, but WB said Already Installed.  So I just uploaded the two moono png's and now a bunch of my toolbar icons are wrong.

What's the best way to revert back to an older version of a module?  I just want to go back, to see if that fixes this issue.

Please ignore.  I figured out how to go back to 4.4.3 and manually "upgrade" (downgrade).  I was really tired when I wrote this post.

When I have more time, I will upgrade again to 4.5.3 and see if I can't figure out what was happening with that icon.

Great work with the development of this crucial module.  Cheers!
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on September 11, 2015, 04:26:11 AM
Pls check again, new package is online. I updated the skin mono

Directdownload (http://addon.WebsiteBaker-next.de/pages/en/browse-add-ons.php?download=08A769F)

Dietmar

Upgraded my 4.4.3 version to this new v4.5.3, and all icons are visible in moono skin.  Thank you very much.
Do you mind if I ask what the issue was?
Title: Re: Can anyone upgrade CKeditor?
Post by: Luisehahne on September 11, 2015, 04:41:38 AM
Hi,

i too upgraded the skin mono.

Dietmar
Title: Re: Can anyone upgrade CKeditor?
Post by: Martin Hecht on September 30, 2015, 08:39:12 AM
Hi,

in the version 4.5.3 from the temporary addons repo at http://addon.WebsiteBaker-next.de/pages/en/browse-add-ons.php?id=08A769F there are two issues:

the most severe for wb 2.8.3 users: include.php makes use of methods in the database class not yet present in 2.8.3.
To make it work again change lines 251-252 as follows:
Code: [Select]
        if (($result = $database->query( $query )) && ($result->numRows() > 0) ) {
            $data = $result->fetchRow( MYSQLI_ASSOC );
(the change is doQuery -> query and fetchArray -> fetchRow )

and another hint: In wb_config, lines 306-307, currently commented out:
Code: [Select]
var urlField = linkTab.get( 'txtUrl' );
urlField['default'] = 'www.example.com';
here the name of the urlField has changed to txtUrl and therefore the subsequent line did not work anymore and someone has commented it out in the version currently provided in the addons repo.

cheers, Martin
Title: Re: Can anyone upgrade CKeditor?
Post by: Luisehahne on September 30, 2015, 02:22:40 PM
the most severe for wb 2.8.3 users: include.php makes use of methods in the database class not yet present in 2.8.3.
To make it work again change lines 251-252 as follows:
Code: [Select]
        if (($result = $database->query( $query )) && ($result->numRows() > 0) ) {
            $data = $result->fetchRow( MYSQLI_ASSOC );
(the change is doQuery -> query and fetchArray -> fetchRow )

we solved it to use with WB 283 and WB 284. We will be going to inform if new version is ready for download.

Quote
and another hint: In wb_config, lines 306-307, currently commented out:
Code: [Select]
var urlField = linkTab.get( 'txtUrl' );
urlField['default'] = 'www.example.com';
here the name of the urlField has changed to txtUrl and therefore the subsequent line did not work anymore and someone has commented it out in the version currently provided in the addons repo.

cheers, Martin

i can't agree. This Lines are for the image Plugin and there is no existing urlField variable, only  a element id: txtUrl.

Like i remember it's a old code snippet for the image plugin in ckeditor 3.x

We remove this lines.

Dietmar



Title: Re: Can anyone upgrade CKeditor?
Post by: Martin Hecht on October 01, 2015, 02:12:14 PM
Hi Dietmar,

i can't agree. This Lines are for the image Plugin and there is no existing urlField variable, only  a element id: txtUrl.
Like i remember it's a old code snippet for the image plugin in ckeditor 3.x

yes, it might be old code and it's not worth discussing a lot. It is  just supposed to put 'www.example.com'  as a predefined value into the URL field.
old code:
Code: [Select]
        if ( dialogName == 'image' )
        {
            // Get a reference to the "Link Info" tab.
            var linkTab = dialogDefinition.getContents('Link');
  //alert(linkTab);
            // Set the default value for the URL field.
            var urlField = linkTab.get( 'Klasse' );
            //urlField['default'] = 'www.example.com';
              //alert(urlField);
        }

in my understanding urlField is a local variable here, which stores the handle to something on the Link tab. There is nothing named 'Klasse' and therefore the local variable urlField is null and the assignment to its default-component fails (and prevents the whole dialog from appearing). The point is that 'Klasse' should be replaced by 'txtUrl'. The name of the variable urlField is irrelevant and it could as well be dropped completely if you decide to write it on a single line:

Code: [Select]
        if ( dialogName == 'image' ) dialogDefinition.getContents('Link').get('txtUrl')['default'] = 'www.example.com';

but it's totally ok to remove the example url completely. Usually, you wouldn't want to have links to www.example.com inserted by default (even if you don't click on the Link-tab at all).

I only wanted to mention this because I still had an old wb_config.js with my local modifications and noticed that this piece of old code did not work anymore (and according to the debugging comments in the release you might just have given up at this place). But again, removing this section completely is probably the best solution.

Martin
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on December 08, 2015, 02:51:06 PM
is it possible to style this 4 buttons, i need a little more width

(https://i.gyazo.com/b398efd93422641b35ef40441f0e6307.png)

i didnt found a class for this  :oops:

a styling for this buttons was possible in cke 3.x via css

i found some styles in the web for the dropdown-list, but it doesnt work in a css-file in template-folder (like earlyer versions), maybe they change the load-order for the css-files
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on December 08, 2015, 03:14:05 PM
Hm, in der wb_theme css eingetragen verändert es die Breite vom Feld Größe (letzter CK)
Code: [Select]
.cke_combo__fontsize .cke_combo_text {
    width: 40px!important;
}

Geht bei dir nicht?
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on December 08, 2015, 03:28:46 PM
i try it in my editor.css in template folder, but this was overwritten from the css-files in ckeditor-folder

your solution with the theme.css works. thx  (Y)
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on December 08, 2015, 06:28:39 PM
For those who can't read dbs' message:
you can style these 4 buttons by editing "theme.css" in your ADMIN theme folder (e.g., wb theme, argos theme)

Also, for those who are not aware, these buttons and their drop-down panels can be styled globally:

Drop-down buttons on toolbar:
.cke_combo .cke_combo_text

Drop-down panels:
.cke_panel


Or individually:

Drop-down buttons on toolbar:
.cke_combo__font .cke_combo_text
.cke_combo__fontsiz e .cke_combo_text
.cke_combo__format .cke_combo_text
.cke_combo__style .cke_combo_text

Drop-down panels:
.cke_combopanel__fo nt
.cke_combopanel__fo ntsize
.cke_combopanel__fo rmat
.cke_combopanel__st yles

e.g.,
to change the width of the drop-down panel for the "Format" button only:

.cke_combopanel__fo rmat {
width: 422px !important;
}

Hope this helps.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on December 09, 2015, 12:18:05 PM
 (Y)
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on December 10, 2015, 08:54:59 AM
+1 from me too.
This is now in the CK as backend.css.

Q: change of width or height of the CK with include or wb_ckconfig has no effect. It is only changable in modify.php of module wysiwyg?

Title: Re: Can anyone upgrade CKeditor?
Post by: DarkViper on December 10, 2015, 09:55:38 AM
Q: change of width or height of the CK with include or wb_ckconfig has no effect. It is only changable in modify.php of module wysiwyg?
This is correct..
The wysiwyg module defines the size how it shall be shown...
The editor itself is an extension, a child of the wysiwyg only and must fit the frame of it's parent.
The behavior and appearance of the editor then is part of it's own settings.

Manuela
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on December 10, 2015, 10:02:08 AM
All clear, thx.
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on December 10, 2015, 03:51:38 PM
+1 from me too.
This is now in the CK as backend.css.

Q: change of width or height of the CK with include or wb_ckconfig has no effect. It is only changable in modify.php of module wysiwyg?

Not sure if I understand your question, but if you are wanting to change the width and height of the CKeditor window, here is how I do it.

*** I use Argos Theme, so I can not comment on other themes.

Argos Theme
header.htt
If you want to allow the CKeditor to break out of the Argos theme.css width. (this is my preferred method)
~ line:56
change:
Code: [Select]
<table cellpadding="0" cellspacing="0" border="0" width="900" align="center">to:
Code: [Select]
<table cellpadding="0" cellspacing="0" border="0" width="the_width_you_want" align="center">
or
If you want to use the Argos theme.css width to control the CKeditor width - you must find and replace all instances of 900px (or whatever your theme default width is) in Argos theme.css, with your desired width.  Be sure to do a 'search & replace' INCLUDING the "px", as there may be instances of the number (900) in styles like colours, and you don't want to accidentally change them.
header.htt
~ line:56
change:
Code: [Select]
<table cellpadding="0" cellspacing="0" border="0" width="900" align="center">to:
Code: [Select]
<table cellpadding="0" cellspacing="0" border="0" width="100%" align="center">
You might be able to add your height in here too, but I prefer to use the CKeditor autogrow feature to handle my editor height.

Hope this helps.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on December 10, 2015, 04:13:03 PM
what you do, is changing the avaiable width for the Box around the Editor, here a table - but it is of course a method to change the editor width without changing some php-files in the module-folder
we need a extra txt-file for all the small tips here ;-)

what we mean, is a basic definition in the CKeditor-Config-File

here the basic configuration from modules / ckeditor / wb_config / wb_ckconfig.js

Code: [Select]
// The standard height and width of CKEditor in pixels.
    config.height           = '250';
    config.width            = '900';

this definition works only, if the function call doesnt submit any values for width & height - normaly set by a module
the module "wysiwyg-editor" use this call
Code: [Select]
show_wysiwyg_editor('content'.$section_id,'content'.$section_id,$content,'100%','350');
means: 100% from the avaiable width (your table around the editor) and 350px height

for my actual module i can use individual call like
Code: [Select]
show_wysiwyg_editor("concert_desc","concert_desc",$content,"500px","200px",$toolbar='Basic');    

gives a small editor and place for other functions (like a preview) on the right side (here empty at the moment)

(https://i.gyazo.com/af3eefa43c46250b52cad3282705d94e.png)
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on December 10, 2015, 04:47:02 PM
Sorry, I didn't understand dbs' question, nor do I understand what you are trying to accomplish or the problem you are facing.  I must have come into a conversation half way.  I will sit back and watch... and learn.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on December 10, 2015, 05:24:25 PM
I will sit back and watch... and learn.

me too   :wink:
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on January 22, 2016, 06:35:02 PM
I have no idea if this is helpful for anyone else, but it suits my needs, and is easy to implement.  Those who know more about CKEditor can let me know if this is a bad idea, or if it might cause problems.

Changing the width of the CKEditor window.  I have this working in WB 2.8.3 SP5, CKEditor ver4.5.5

/modules/ckeditor/backend.css
add
.cke { width: the_width_you_want !important; }
for instance, on one site, I use:
.cke { width: 800px !important; }

This works on WYSIWYG, News and bakery CKEditor windows from my testing.

If you use a smaller width than the container and don't like the empty space to the right of the editor in WYSIWYG pages, you can "tighten" the look up in your admin theme (only tested in argos_theme):
argos theme/theme.css
add your desired width (margin for centering, optional) to .block-outer class.

.block-outer {
    padding: 3px 3px 0;
    border: 1px solid #DEE5F8;
    border-radius: 5px;
    margin-bottom: 25px;
    box-shadow: 1px 1px 5px #666;
    width: 802px;
    margin: 0 auto;
}


For height adjustment, as mentioned in an earlier post, I use the AutoGrow plugin.  The latest version of the autogrow plugin at this time is 4.5.6 (attached).  But check the CKEditor site for the version which matches your installed CKEditor version - http://ckeditor.com/addon/autogrow (http://ckeditor.com/addon/autogrow)

For those who aren't familiar with this plugin and are interested, this is how I implement autogrow:

Extract the downloaded plugin .zip.
create a folder named "autogrow", in your CKEditor module, under plugins - /ckeditor/plugins/autogrow
upload the extracted plugin.js file into the autogrow folder you just created

Enable the plugin - I like to make my CKEditor changes in my_admin_template/editor/wb_ckconfig.js file.  To be able to do this, I had to make a change to a line which was added in the include.php file of CKEditor ver4.5.5 (not sure if this is recommended or not, but I have not had any negative issues so far):
CKEditor/include.php
~line81
from
    $bWbConfigSetting = false;
to   
    $bWbConfigSetting = true;

Then add your desired settings to my_admin_template/editor/wb_ckconfig.js
starting ~line 118, right under "Define all extra CKEditor plugins in _yourwb_/modules/ckeditor/ckeditor/plugins here", add:

// Define all extra CKEditor plugins in _yourwb_/modules/ckeditor/ckeditor/plugins here
//AutoGrow Settings
   config.autoGrow_min Height = 50;
   config.autoGrow_max Height = 600;
   config.autoGrow_onS tartup = true;
   config.autoGrow_bot tomSpace = 20;
  //config.extraPlugins = 'timestamp';
    config.extraPlugins  = 'autogrow,justify,find,flash,colorbutton,colordialog,dialogadvtab,'

You can read about all the settings here - http://docs.ckeditor.com/#!/guide/dev_autogrow

Hope this helps.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on January 23, 2016, 04:29:37 PM
I have no idea if this is helpful for anyone else, but it suits my needs, and is easy to implement.  Those who know more about CKEditor can let me know if this is a bad idea, or if it might cause problems.

it makes no problems and if its work for you, its okay
Title: Re: Can anyone upgrade CKeditor?
Post by: Luisehahne on February 17, 2016, 03:45:13 PM
Dear WebsiteBaker Users,
Dear WebsiteBaker community,

After hard testing the CKEditor, we are very proud to publish the new CKEditor version 4.5.6 (http://addon.WebsiteBaker.org/pages/en/browse-add-ons.php?id=08A769F) including all fixes we can do for ourself.

Some Fixes like the ratio issue can only do by CKEditor Devs (http://dev.ckeditor.com/).

Dietmar

Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on February 17, 2016, 06:03:28 PM
Dear WebsiteBaker Users,
Dear WebsiteBaker community,

After hard testing the CKEditor, we are very proud to publish the new CKEditor version 4.5.6 (http://addon.WebsiteBaker.org/pages/en/browse-add-ons.php?id=08A769F) including all fixes we can do for ourself.

Some Fixes like the ratio issue can only do by CKEditor Devs (http://dev.ckeditor.com/).

Dietmar

Fantastic work on this essential module.  I have noticed one thing.  I have upgraded a few websites (both local and live) from vCKEditor v4.5.5.  The upgrade does smoothly, but when I go into cwsoft-addon-file-editor, the CKEditor is still listed as "CKEditor v4.5.5".  I've tried "reload", but it does not change.  The only way I can get the v4.5.6 to show in the cwsoft-addon-file-editor listing is to first uninstall CKEditor v4.5.5 and then install v4.5.6.

And yes, I did choose "Overwrite newer Files" when installing.

Not sure if this has anything to do with this issue, but I did this fix on these websites - http://forum.WebsiteBaker.org/index.php/topic,28901.msg202658.html#msg202658
Title: How to edit the Plugin wbrelation?
Post by: jacobi22 on February 17, 2016, 06:05:17 PM
one part of the latest CKeditor-package is the Plugin wbrelation

This plugin build some additional Fields in image-Link-Dialog and also in image-advanced Dialog

(https://i.gyazo.com/dafb0adb1be6e73d73bdc083a83b37b9.png) (https://i.gyazo.com/cd4f05212b9a78c7d9f349f3a41d8395.png)

its possible, to change this default settings and build your own standard value or, if you want, a select box with different styles
Important: if you set a standard value in the plugin.js, you have this as standard value in every new img- or link-code, so be carefull

here a example img + picture link with all additional infos
Code: [Select]
<a class="my_css_class" href="http://mypicture.com/picture1.jpg" rel="colorbox" target="_self" title="My Link-Title">
<img alt="" class="img-responsive" dir="ltr" height="560" id="MyID1" lang="DE" id="MyID1" longdesc="Long-Description" src="http://mypicture.com/picture1_thumb.jpg" style="border: 1px solid rgb(255, 0, 0);" title="My Picture Title" width="700" /></a>

How To:
you need only the file modules / ckedito / ckeditor / plugins / wbrelation / plugin.js

1. advanced dialog
at first the standard value on the advanced dialog. the advanced dialog set additional informations to the img-Tag only (CSS-Class, Title, ID, Stylesheet etc)
some users ask about this. they use the standard value css-class for the image, called "img-responsive". i use in my project a different name, so i need a new standard valu in this field.
the definition for this field is in line 87
Code: [Select]
cssField['default'] = 'img-responsive';
feel free to use a new default or also a empty field
Code: [Select]
cssField['default'] = '';
2. the link-dialog

this setting works only in the a-Tag, the link around the selected image, maybe to show a big version with lightbox effects etc

the relation-attribute
it set the rel-attribute for lightbox-effects, use in colorbox or other scripts. its possible to set here also a standard value, in my example the relation "colorbox"

Line 108
Code: [Select]
'default' : 'colorbox',
feel free to change it in a different name or to a empty value
Code: [Select]
'default' : '',
its possible to set here a selectbox like my picture in the bottom. if you work with a selectbox, its not possible to use a new relation, you can only use the value's from the list or a empty field. but a list with fixed values is good, if you have editors in the backend, they can only choose a name from the list and not using a wrong name with no definition in your lightbox

here a original code with a single value (can be overridden by user)
line 104 - Line 108
Code: [Select]
                                type : 'text',
                                label : editor.lang.wbrelation.rel,
                                'default' : 'colorbox',
                                id : 'cmbRel',
                                setup : function()

code for a selectbox on the same place
Code: [Select]
id: 'cmbRel',
                                type: 'select',
                                label: editor.lang.wbrelation.rel,
                                style: "width: 150px;",
                                items:
                                    [
                                        [ editor.lang.wbrelation.notset ],
                                        [ "Fancybox",      "fancybox" ],
                                        [ "Lightbox",      "lightbox" ],
                                        [ "PrettyPhoto",   "prettyPhoto" ],
                                        [ "Alternate",     "alternate" ],
                                        [ "Copyright",     "copyright" ],
                                        [ "Designates",    "designates" ],
                                        [ "No follow",     "nofollow" ],
                                        [ "Stylesheet",    "stylesheet" ],
                                        [ "Thumbnail",     "thumbnail" ]
                                     ],
                                setup : function()

scheme for the values:
items: [ "Fancybox",      "fancybox" ]
- every line is a option in the select-box
- first Part: Name in the List
- second Part: value for the class

feel free to add or delete some lines and edit the names there

the field for css-class (Stylesheet Class) works analog

original-code

Code: [Select]
type : 'text',
                                label : editor.lang.wbrelation.cssClasses,
                                'default' : '',
                                id : 'cmbClass',
                                setup : function()

selectbox

Code: [Select]
id: 'cmbClass',
                                type: 'select',
                                label: editor.lang.wbrelation.cssClasses,
                                style: "width: 180px;",
                                items:
                                    [
                                        [ editor.lang.wbrelation.notset ],
                                        [ "class1",   "class1" ],
                                        [ "class2",   "class2" ],
                                        [ "class3",   "class3" ],
                                        [ "class4",   "class4" ]
                                     ],

                                setup : function()

but dont forget: its not possible for a backend-user, to change a value from a select-box

here the result of the last code
(https://i.gyazo.com/4d7ba075f24f29d3a22d2ae766ff4983.png)
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on February 17, 2016, 06:07:42 PM
I have noticed one thing.  I have upgraded a few websites (both local and live) from vCKEditor v4.5.5.  The upgrade does smoothly, but when I go into cwsoft-addon-file-editor, the CKEditor is still listed as "CKEditor v4.5.5".  I've tried "reload", but it does not change.  The only way I can get the v4.5.6 to show in the cwsoft-addon-file-editor listing is to first uninstall CKEditor v4.5.5 and then install v4.5.6.

do you have the same issue in menu addons->modules-> module details
or only in the afe?

P.S. after check the files in both zip's (SP6 + Single CKE): looks for me, that they not upgrade the databasetable "addons"
please try, to start a manual module reload (addons -> advanced-> controlbox for modules -> Reload)

The AFE use the Module Name from this database table "addons"
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on February 17, 2016, 06:22:43 PM
I couldn't find my v4.5.5, but I reverted to v4.5.3 and then did the upgrade to v4.5.6, and yes, the issue is in add-ons - modules as well:
Code: [Select]
Module Details
Name:    CKEditor v4.5.3
Type:    WYSIWYG Editor
Author:    Michael Tenschert, Dietrich Roland Pehlke, erpe, WebBird, Marmot, Luisehahne
Version:    4.5.6
Designed For:    Website Baker 2.8.3 SP6
Description:    includes CKEditor 4.5.6 Standard, CKE allows editing content and can be integrated in frontend and backend modules.

Quote
manual module reload (addons -> advanced-> controlbox for modules -> Reload)
did the trick.  Thanks!
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on February 17, 2016, 06:32:12 PM
Can confirm, have ckeditor 4.4.7 displayed in details (after upgrade to SP6, local, PHP5.5)
Also after reload modules.
Title: Re: Can anyone upgrade CKeditor?
Post by: CodeALot on February 20, 2016, 02:03:47 AM
Installed 4.5.6 and the whole editor disappeared.
Uninstalled the whole thing, reinstalled: no change.
Oh well. We have backups.
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on February 20, 2016, 06:02:57 AM
Found a new little bug in v4.5.6, which I can't reproduce on older versions.

If you double click a text link, or right click and choose edit link, then immediately click "Cancel" without making any changes, you get this dialogue:
(https://i.gyazo.com/15ece68f9ad84a1bd72e5505dc049522.png)
Title: Re: Can anyone upgrade CKeditor?
Post by: hgs on February 20, 2016, 07:49:48 AM
Das kann ich bestätigen.
Wenn mann dann im Dialog den Hacken setzt, "Seite daran hindern einen Dialog zu öffnen" kann man nicht mehr mit "Abbrechen" den Dialog verlassen, sondern nur noch mit "OK"

Google English
I can confirm that.
If one then sets the chopping dialog, "page it prevent to open a dialogue" can no longer rely on "Cancel" dialog you, but only with "OK"
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on February 20, 2016, 12:32:25 PM
Installed 4.5.6 and the whole editor disappeared.
Uninstalled the whole thing, reinstalled: no change.
Oh well. We have backups.

Minimum for CKeditor-Version 4.5.6 is WB 2.8.3 SP4 - whats you WB-Version?
Whats your charset in WB, your PHP-Version etc.

a simple "it doesnt work" is not realy a help  :roll:
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on February 20, 2016, 12:40:08 PM
Found a new little bug in v4.5.6, which I can't reproduce on older versions.

If you double click a text link, or right click and choose edit link, then immediately click "Cancel" without making any changes, you get this dialogue:

confirmed  :oops:

only information:
the ckeditor-group change the whole code for the LINK-Dialog in vers 4.5.6, but in wb we use the wblink-plugin. so maybe, the same problem come's also in other dialog's, using the wb-link
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on February 20, 2016, 01:05:17 PM
Error doesnt exist in the original link-plugin - that's good

now only found the correct line(s) to fix it  :roll: :roll: :roll: :-D
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on February 20, 2016, 02:32:27 PM
difficult to explain it in a foreighn language......

this popup message with the controlbox (post from hgs) is a browser message and has nothing to with the ckeditor. (but the first popup, showed in post from sky_writer)
this popup come's, if the same popup is show'n multiple times - in every case, in every browser message

you wrote:
Quote from:  sky writer
Found a new little bug in v4.5.6, which I can't reproduce on older versions.

not realy correct  :wink:
try to change something in one of the input fields in a older cke-version, doenst matter, where in the dialog tab's, now click on cancel (without saving anything)
result: the browser inform to, that you lost this changes, if you now cancel this dialog

the different between older and the 4.5.6-version btw the original link-dialog (my last post):  the browser inform you also about changes, if you have not changes  :roll:

we'll search for this, i'm sure, thats only a little different somewhere in the 800 line's

@hgs: the dialog-popup is a browser-action. if you activate the controlbox "Dont show more Dialog messages about this", you say to the browser exact this and because of this, its not possible to get out of this Link-Dialog - you have to confirm first, that its okay to lost some (possible) changes

P.S.: the browser save your choice in this dialog "Dont show more Dialog messages about this" for this domain. So its possible, that you have problems in the next link dialog, if you try to cancel
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on February 20, 2016, 04:39:17 PM
Quote from:  sky writer
Found a new little bug in v4.5.6, which I can't reproduce on older versions.
not realy correct  ;)
try to change something in one of the input fields in a older cke-version, doenst matter, where in the dialog tab's, now click on cancel (without saving anything)
result: the browser inform to, that you lost this changes, if you now cancel this dialog

the different between older and the 4.5.6-version btw the original link-dialog (my last post):  the browser inform you also about changes, if you have not changes  ::)
For clarification, can you please tell me what you mean by "btw"?  For me, in English, this means "by the way", but that doesn't seem to fit in your sentence.  I see you use "btw" a lot and I have never been able to figure out the translation.  I want to understand you.

Why is my statement "not really correct"?  I would expect a warning dialogue like this if I make changes and then click "cancel" (as is the case in all CKEditor versions), I would not call this a bug.  I would call it a good feature.  But when I do not make changes and then click "Cancel" (v4.5.6), getting this warning dialogue is not expected or wanted.  It could be confusing to the user.

we'll search for this, i'm sure, thats only a little different somewhere in the 800 line's

There may be something lost in translation, but the tone of your reply suggests that my reporting this "bug" is not really welcome, or somehow gives the impression that I am demanding an immediate fix.  I am not telling you to search through 800 lines of code and fix this issue.  I am not asking for anything.  I am simply reporting on something that I found.  I thought these kinds of reports were helpful and wanted by developers, in hopes of improving their work.

If the tone of your reaction is because of my use of the term "bug", then I will stop using that term.  I realize that the term "bug" is sensitive to some developers.  I usually use "issue" or "problem", but in this instance, I know it was not a user error on my part, but something specific to v4.5.6.

I was just trying to help.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on February 20, 2016, 05:48:19 PM
Quote
Why is my statement "not really correct"?

this here is not correct -> which I can't reproduce on older versions

this message its a part of every editor, also Tiny or FCK and the first ckeditor version, but this message come's only, if you change something from the in database readed values

and now, in CKE 4.5.6, it come's without changes

Quote
For clarification, can you please tell me what you mean by "btw"?
sorry for that  :oops: :oops: :oops:  come from the german "bzw" - in german short for beziehungsweise - the translater give's me this -> respectively

the ckeditor upgrade the complete code for the LINK-plugin in vers. 4.5.6 . To use wblink's in the LINK-Dialog, maybe as a target, we use a variation of this original LINK-Plugin. But i found no special code for the cancel-action in this plugin

Quote
but the tone of your reply suggests that my reporting this "bug" is not really welcome

????????????????????????   :roll: :roll: :roll: :oops: :oops: :oops:
i've tried to explain, who it works (not more) and i confirm your report:
the browser tells me, i have some changes, but i dont change anything, so its work not like the older version

its okay, if the browser open your showed popup window, but only, if i make a change, and not without that

we need this bug reports, its important for the development
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on February 20, 2016, 05:52:56 PM
read the post again and think, its better, i stop my work here for any day's

maybe, you can explain for me, where do you see  the bad "tone"

have a nice weekend
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on February 20, 2016, 08:19:30 PM
problem is locatet

deactivate this lines  (two // in the front of this line)

'use strict';

in
ckeditor / plugins / wblink / dialogs / wblink.js  and
ckeditor / plugins / wblink / plugin.js

P.S.: 'use strict' is a recommened setting for ckeditor plugin developers and also used in any ckeditor plugins (like autogrow). if you (or other users) has other problems, search in this plugin-folder in plugin.js or in the dialogs-subfolder for a line with this content ('use strict') and deaktivate this line
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on February 20, 2016, 11:05:50 PM
Quote
Why is my statement "not really correct"?

this here is not correct -> which I can't reproduce on older versions

this message its a part of every editor, also Tiny or FCK and the first ckeditor version, but this message come's only, if you change something from the in database readed values

and now, in CKE 4.5.6, it come's without changes

Quote
For clarification, can you please tell me what you mean by "btw"?
sorry for that  :-[ :-[ :-[  come from the german "bzw" - in german short for beziehungsweise - the translater give's me this -> respectively

the ckeditor upgrade the complete code for the LINK-plugin in vers. 4.5.6 . To use wblink's in the LINK-Dialog, maybe as a target, we use a variation of this original LINK-Plugin. But i found no special code for the cancel-action in this plugin

Quote
but the tone of your reply suggests that my reporting this "bug" is not really welcome

 :? :? :? :? :? :? :? :?   ::) ::) ::) :-[ :-[ :-[
i've tried to explain, who it works (not more) and i confirm your report:
the browser tells me, i have some changes, but i dont change anything, so its work not like the older version

its okay, if the browser open your showed popup window, but only, if i make a change, and not without that

we need this bug reports, its important for the development

I apologize for giving the impression that I thought you had a "bad" tone.  I think something is still getting lost in translation in both directions.  I was not complaining, I was trying to seek clarification, and help us move forward.

Quote
this here is not correct -> which I can't reproduce on older versions
Your stance still does not make sense to me.  I can not reproduce this issue in any other version.  I totally understand that the warning dialogue has always been present in the past editor versions, but the issue I reported is that when you open a link dialogue and make no changes and click Cancel, you get this unnecessary warning dialogue.  I can not reproduce that behavior in any editor version other than 4.5.6.  You state this yourself:
Quote
and now, in CKE 4.5.6, it come's without changes
I don't want to argue the point, as the debate must be being triggered by more translation nuances, since you seem to be agreeing with me in your later paragraphs.

Quote
sorry for that  :-[ :-[ :-[  come from the german "bzw" - in german short for beziehungsweise - the translater give's me this -> respectively
Thank you for the effort, but "Respectively" doesn't really fit either.  But there is an alternate translation - "but rather".  Could this be what you mean.  "But rather" would be like saying "more specifically", or "more to the point".  Could this be more accurate?
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on February 21, 2016, 04:16:06 AM
problem is locatet

deactivate this lines  (two // in the front of this line)

'use strict';

in
ckeditor / plugins / wblink / dialogs / wblink.js  and
ckeditor / plugins / wblink / plugin.js

P.S.: 'use strict' is a recommened setting for ckeditor plugin developers and also used in any ckeditor plugins (like autogrow). if you (or other users) has other problems, search in this plugin-folder in plugin.js or in the dialogs-subfolder for a line with this content ('use strict') and deaktivate this line

Thank you very much for the fix and information about other plugins as well.

Have a great weekend!
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on February 21, 2016, 01:28:04 PM
Quote
I see you use "btw" a lot and I have never been able to figure out the translation.  I want to understand you.

i ask some german's and everybody know's or understand, what i mean  - maybe that a result of our english-german mix (called "denglish" - deutsch(german)+english). i work in a lot of countrys here in europe and i remember, that sometimes the people's look with very big eyes and ask again like this ->  :roll: :roll: :roll:

i try it again - english lesson for beginners - part 1  :-D :-D
example:
Quote
the different between older and the 4.5.6-version btw the original link-dialog

means in simple words:
the differents between older and the 4.5.6-version and also the differents between older (versions) and the original link-dialog

you can also replace the words "and also" with especially or specially

now your turn ;-)


Title: Re: Can anyone upgrade CKeditor?
Post by: CodeALot on February 21, 2016, 10:53:32 PM
In English, the abbreviation "btw" is a 'chatty-abbreviation" that stands for By The Way.
That's why he didn't understand.
Title: Re: Can anyone upgrade CKeditor?
Post by: CodeALot on February 21, 2016, 10:57:43 PM
Installed 4.5.6 and the whole editor disappeared.
Uninstalled the whole thing, reinstalled: no change.
Oh well. We have backups.

Minimum for CKeditor-Version 4.5.6 is WB 2.8.3 SP4 - whats you WB-Version?
Whats your charset in WB, your PHP-Version etc.


It wasn't so much a 'cry for help' :), I assumed it was just a small bug and decided to wait for the next version.

But! Miracles do happen. Just when I decided to get the backup, the CKEditor decided to work after all. So it's all good now. No idea what went wrong the first time.
 
CMS Version 2.8.3 SP5
Revision 1644
Title: Remove <p>-Tags around droplet-call
Post by: jacobi22 on March 15, 2016, 08:00:31 PM
in most case's, if i insert a droplet via ckeditor-dialog, the editor add a p-tag around the [[DROPLET]], but its not valide every time.
i can set the editor-setting config.enterMode to br or div, but this work for the whole editor
i can also add a open and closed tag around the Droplet-Name in modules / ckeditor / ckeditor / plugins / wbdroplet, but its gone in the next upgrade

so i search for a solution for everybody or a solution, used only in my individual wb_ckconfig.js in template-folder, maybe a preg_replace (replace [[ && ]] with <div class="droplet">[[DROPLET]]</div>  )

has anybody a solution for that?
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on March 15, 2016, 08:56:38 PM
No solution, but i can need a answer too.
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on March 15, 2016, 09:42:24 PM
I don't think I fully understand your issue.  All I do when I don't want a p-tag around an element, like a droplet is to highlight it and choose paragraph style "Normal (DIV)", which places a div around the element.  Will this not work in your situation?
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on March 15, 2016, 09:56:51 PM
... or perhaps "Create Div Container" around droplet, if you want to add a style?
Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on March 15, 2016, 10:00:12 PM
I think a droplet can contain his own html-structure, in this case a wrapped container is unwanted.
Title: Re: Can anyone upgrade CKeditor?
Post by: Ruud on March 15, 2016, 11:39:23 PM
I think a droplet can contain his own html-structure, in this case a wrapped container is unwanted.
Droplets can contain everything.. From a simple "hello world" up to... anything..

If you are really worried about valid html, start the output of your droplet with a </p> and end it with a new <p>.
If that is not good enough, don't use droplets but build a pagemodule for whatever you need to do.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on March 16, 2016, 10:35:47 AM
@ Ruud:  but i dont know in every case, do i need a closed </p> on exact this place or not

for me no problem, i can work with HTML-Source-Code, but not every Users will do that. i think, its possible, to add some code around the droplet-name , directly in the droplet-plugin (build a output like this ->

Code: [Select]
<div class="droplet">[[DROPLET-NAME]]</div>
but is it a solution for everybody or make's it trouble?. The way from Sky Writer is of course possible, but in the result the same problem. i have to look into the source-code and check my code

some examples
1. a empty editor field, insert a droplet via droplet dialog, result is this
Code: [Select]
<p>[[EmailFilter]]</p>also no problem, if you use ENTER or SHIFT+ENTER

2. a simple pic in p-tags, click nearly to the pic, to add a droplet, result: insert the droplet inside of the p-tag like
Code: [Select]
<p>
<img alt="" height="50" src="picture.jpg" style="" width="100" />[[EmailFilter]]</p>

add my dropletcode now a Div-block or my solution with a fixed div around the droplet, the code is invalid, its not allowed, to have a div inside of a p-tag. Here Ruud#s solution works, the code is valid, but it produced a new empty line's at the end of the droplet, like
Code: [Select]
<p>
<img alt="" height="50" src="picture.jpg" style="" width="100" /></p><div class="droplet">[[EmailFilter]]</div><p></p>

the advance in my solution with the fixed div is, that the ckeditor doesnt add a p-tag around the droplet, if he found a div  - so i have valid code, if my droplet content has also a div or other tags

Title: Re: Can anyone upgrade CKeditor?
Post by: dbs on March 18, 2016, 07:27:45 PM
For me it helps to set this from true to false in wb_ckconfig.js
Code: [Select]
config.autoParagraph = false;
Title: Re: Can anyone upgrade CKeditor?
Post by: zirzy on March 29, 2016, 10:32:47 AM
Hi,

Adding images don't work in Chrome, Mozilla, Opera and IE browsers with CKEditor_v4.5.7



Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on March 29, 2016, 10:37:49 AM
Hi,

Adding images don't work in Chrome, Mozilla, Opera and IE browsers with CKEditor_v4.5.7

cannot confirm - works in all browsers for me - do you have the latest version from here (http://addon.WebsiteBaker.org/pages/en/browse-add-ons.php?id=08A769F)?
(its the module from the SP6 as single download)
Title: Re: Can anyone upgrade CKeditor?
Post by: zirzy on March 29, 2016, 10:58:51 AM
yes, first it did not work from SP6 and then I installed this new version 4.5.7 a few minutes ago and still the same problem..
Title: Re: Can anyone upgrade CKeditor?
Post by: CodeALot on March 29, 2016, 01:26:27 PM
cannot confirm - works in all browsers for me

Same here. Flawless in 2.8.3+SP6 and CKEditor 4.5.7
Title: Re: Can anyone upgrade CKeditor?
Post by: zirzy on March 29, 2016, 02:31:34 PM
Tested with my mac and pc and it doesn't add the dialog box where I can choose picture etc. Just light screen is in front of the wysiwyg. I have to reload page to get back on track. All other tools is working correctly.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on March 29, 2016, 02:38:09 PM
some possibility's.....
in our test's some users reports a problem like your in the (original) image plugin - we found a issue in the plugin wbrelation (is fixed). you can try to deactivate this wbrelation-plugin
for this, go into the include.php of the ckeditor, search there for the line with the definition of the $ckeditor->config['extraPlugins']
remove here the last plugin wbrelation and set this to the next array -> $ckeditor->config['removePlugins']

after every changes, its important, to start a new instance of the ckeditor, switch from the editor area to maybe AdminTools and then back to your page

if you use other plugins like image2, imageresponse etc, deactivate this plugins also

the image plugin use also the plugins wblink, wbrelation & dialogadvtab 

P.S.: to test the basic function, its recommened to deactivate possible working wb_ckconfig.js in your templates (simple rename) and (if changed!!) also the wb_ckconfig in modules / ckeditor / wb_config
Title: Re: Can anyone upgrade CKeditor?
Post by: zirzy on March 30, 2016, 11:39:14 AM
some possibility's.....
in our test's some users reports a problem like your in the (original) image plugin - we found a issue in the plugin wbrelation (is fixed). you can try to deactivate this wbrelation-plugin
for this, go into the include.php of the ckeditor, search there for the line with the definition of the $ckeditor->config['extraPlugins']
remove here the last plugin wbrelation and set this to the next array -> $ckeditor->config['removePlugins']

after every changes, its important, to start a new instance of the ckeditor, switch from the editor area to maybe AdminTools and then back to your page

if you use other plugins like image2, imageresponse etc, deactivate this plugins also

the image plugin use also the plugins wblink, wbrelation & dialogadvtab 

P.S.: to test the basic function, its recommened to deactivate possible working wb_ckconfig.js in your templates (simple rename) and (if changed!!) also the wb_ckconfig in modules / ckeditor / wb_config


Thanx jacobi22! Now it is working correctly again  (Y).

Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on March 30, 2016, 01:49:51 PM
what was your solution now?

remove the wbrelation-plugin??
i remember, that the ckeditor-group change the code from the original link-plugin and because of this, we have to change also our wb-specific plugins wblink and the old relation-plugin for some additional fields in the link- and image-dialog-windows (like a relation-Tag)
i know, that nobody from the actual tester group here use a mac, so its difficult to see a problem in a plugin and fix this
Title: Re: Can anyone upgrade CKeditor?
Post by: zirzy on March 30, 2016, 02:31:09 PM
what was your solution now?

remove the wbrelation-plugin??
i remember, that the ckeditor-group change the code from the original link-plugin and because of this, we have to change also our wb-specific plugins wblink and the old relation-plugin for some additional fields in the link- and image-dialog-windows (like a relation-Tag)
i know, that nobody from the actual tester group here use a mac, so its difficult to see a problem in a plugin and fix this

Yes, I removed wbrelation-plugin.

First I saw this on my pc and then I tested this on mac and there it was too.. But now it is fixed :)


Title: Re: Can anyone upgrade CKeditor?
Post by: olivier on November 27, 2016, 11:03:26 PM
what was your solution now?

remove the wbrelation-plugin??
i remember, that the ckeditor-group change the code from the original link-plugin and because of this, we have to change also our wb-specific plugins wblink and the old relation-plugin for some additional fields in the link- and image-dialog-windows (like a relation-Tag)
i know, that nobody from the actual tester group here use a mac, so its difficult to see a problem in a plugin and fix this

Hello,
In the toolbar of the CKEditor version 4.5.10 I miss the possibility to link to another page of the website. Of course I can use the button for an (internal) link, but there I can not browse to the page I want; in the fckeditor that was possible.
Does somebody know a solution?
Thanks in advance,
Olivier
 
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on November 27, 2016, 11:42:47 PM
Highlight link element - click the Link icon.
Choose Link Type - WB-Link
WB-Page - the internal page you would like to link to.

(https://i.gyazo.com/08844fc405abb3badceda3cd96110778.gif)
Title: Re: Can anyone upgrade CKeditor?
Post by: olivier on November 28, 2016, 11:48:24 AM
Hello Sky Writer, thank you so much for this quick answer with full solution.
Have a nice day
and greetings, Olivier
Title: Re: Can anyone upgrade CKeditor?
Post by: zirzy on January 03, 2017, 02:33:17 PM
Hi,

There is a new problem with CKeditor 4.5.10. When I try to add an image to the page and I click the browse button --> Browser starts to download browser.html file and I can't insert image to my page.

What to do?

(https://i.imgsafe.org/ba7a07bb9c.jpg)
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on January 03, 2017, 03:23:47 PM
do you use a file called .htaccess in the root directory of wb (not htaccess.txt!) ?

if yes, search for this line here and deactivate it with a # in the front of this line

Quote
    AddType application/x-httpd-php .html

Older Versions of CKeditor like 4.2.2 has a .htaccess in the folder ckeditor / ckeditor. If you have a file with this name in this folder, rename it to htaccess.txt
Title: Re: Can anyone upgrade CKeditor?
Post by: zirzy on January 04, 2017, 11:22:24 AM
Hi jacobi22,

Thanks for advice, now adding image works correct again :) (Y) (Y)
Title: Re: Can anyone upgrade CKeditor?
Post by: daydreamer on March 08, 2017, 07:02:15 AM
WBLINK blank and when I try add link the page just fades out and have to reload!
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on March 08, 2017, 10:41:52 AM
CKEditor Version?
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on April 06, 2017, 08:40:07 PM
WB 2.10.0   CKEditor 4.6.2

Noticed this first in News module, but seems to be the case in any WYSIWYG section.

If only a single line is input, and the line is not followed by the Enter/Return key, then no Paragraph tag is added to that line of text.
Looks like this:
Code: [Select]
This line should have Paragraph FormattingInstead of this:
Code: [Select]
<p>This line does have Paragraph Formatting</p>
If you hit Enter / Return key then the paragraph tags are added to the first line and subsequent lines.

This gives strange results on News overview pages and AnyNews pages.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on April 07, 2017, 12:53:19 AM
go into the modules / ckeditor / include.php  ~ Ln 130  and set  autoParagraph to true like

if (!$bWbConfigSetting ) { $ckeditor->config['autoParagraph'] = true; }
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on April 07, 2017, 12:59:29 AM
Thank you.  I knew that setting was somewhere, but I was looking in the wrong file ( wb_ckconfig.js ).

What version of CKEditor did that setting get changed?... and why?
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on April 07, 2017, 01:08:13 AM
i compare the version's in SP7 and WB 2.10.0

i dont know, why or i dont remember  :oops:
Title: Re: Can anyone upgrade CKeditor?
Post by: sky writer on April 07, 2017, 01:38:58 AM
I remember you (and others, including myself) discussing something related, earlier in this thread:
http://forum.WebsiteBaker.org/index.php/topic,25334.msg203825.html#msg203825 (http://forum.WebsiteBaker.org/index.php/topic,25334.msg203825.html#msg203825)

But I didn't know that the setting had been changed officially.

Having AutoParagraph set by default to false can cause unexpected issues.  For instance, when a single paragraph is entered in the short content of a News article.  AnyNews will display the resulting Title and Short content on the same line, instead of two lines.  I'm sure there are other places it might cause issues.

EDIT: Ah... now I see the suggestion - http://forum.WebsiteBaker.org/index.php/topic,25334.msg203880.html#msg203880
Perhaps this led to the change.  In my opinion, this should be default "true" and manually set to "false" if the user feels it is necessary.  But that's just my feeling.
Title: Re: Can anyone upgrade CKeditor?
Post by: jacobi22 on April 07, 2017, 01:55:33 AM
we scan the forum many times every day for problems and solutions, so maybe the linked post was the point to change it in the editor.

Quote
In my opinion, this should be default "true" and manually set to "false" if the user feels it is necessary.  But that's just my feeling.

 (Y)
i've the same problems in anynews, i think, you're right

P.S.: i add a ticket for that