WebsiteBaker Community Forum
General Community => WebsiteBaker Website Showcase => Topic started by: mopey on April 21, 2008, 06:09:54 PM
-
So, here's a port of the simple beauty template found at oswd. I attached the screenshot and the template. The first screenshot has a custom banner and the second is what you get on a default install.
[gelöscht durch Administrator]
-
Hello,
and where is the template for testing?
Matthias
-
Here is the default. http://engr.isu.edu/pages/test.php
It doesn't validate, but only because the show_menu function adds a target attribute (not sure why). Anyway, I'll change the doctype to transitional rather than strict and it shouldn't be an issue.
-
ok validates now. But I still don't get why you WebsiteBaker folks opted for the show_menu function to spit out non-valid strict html. Not that I care really at all (I'm far from a validation nut). so I attached an updated template. the only thing changed is the doctype.
[gelöscht durch Administrator]
-
Lot of people like the target, but showmenu is fairly old anyway. A lot of the templates may depend on it.
ShowMenu2 (can) generates valid markup and is going to be included in WB 2.7
-
I do like show_menu2(), and I'm glad it's being included. Though show_menu2 also will spit out the target at least by default... I think (at least I couldn't get it to not include the target).
$aMenuOpen has an attribute
[target] Page target for the <a> tag
that looks promising. But both
[a] <a> tag (no class): '<a href="[url]" target="[target]">'
[ac] <a> tag including class: '<a href="[url]" target="[target]" class="[class]">'
specify a target (which I managed to set 'target=""' but couldn't get rid of the target completely).
Not only that, the target attribute seems to be builtin to the core. eg class.frontend, template.inc, many of the admin pages, etc. I think it would be more of a pain than it's worth to change (and like you said, a lot of people like the target attribute). But it isn't valid strict xhtml >= 1.0. Anyway, maybe the showmenu2 page should specify that it generates valid "transitional xhtml 1.0" rather than "xhtml"? Or maybe I just can't get it working properly.
-
Hello,
Or maybe I just can't get it working properly.
You give the answer to your question in the post above yourself. :wink: . It is very simple and directly in front of your eyes, think even to simple that you see it. :-D.
simply change $aItemOpen parameter wich is default:
'[li][a][menu_title]</a>'to:
'[li]<a href="[url]">[menu_title]</a>'
This gives you a link without target
Matthias
-
ahh, yes. Thanks Matthias.